FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add import project from remote support by abhishekmsingh · Pull Request #2348 · python-gitlab/python-gitlab · GitHub

Repository navigation

feat: add import project from remote support - #2348

Merged
nejch merged 3 commits into
python-gitlab:mainfrom
abhishekmsingh:main
Nov 1, 2022
Merged

nejch merged 3 commits into
python-gitlab:mainfrom
abhishekmsingh:main

Conversation

Copy link
Copy Markdown
Contributor

resolves #2260

abhishekmsingh marked this pull request as draft October 29, 2022 19:58
abhishekmsingh marked this pull request as ready for review October 31, 2022 20:42

abhishekmsingh commented Oct 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@nejch can you please have a look on this PR?

  • On implementation of the rmote_import function, I have basically copied the logic from import_project, since the common code was not large enough to be refactored, I think into Mixin or a private function. Feel free to suggest any refactoring techinique I can use.
  • On testing, have added kind of a negative functional test which asserts the expected error. I have verified the error from the gitlab spec, here. I am using a ftp url which violates the validate_url predicate there and hence the error.
  • I am not including s3 support here, will add that as separate PR, linked to separate issue(maybe I can raise it), once this goes through. This is my first one here so want this to be a little atomic :)
    Thanks.

nejch commented Oct 31, 2022

Copy link
Copy Markdown
Member

@abhiandthetruth that makes sense! Will check again in a bit, and sure you can go ahead with a separate issue. Yes, currently when we add custom methods it still means copying a bit of code, that needs some rework later.

nejch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks again @abhiandthetruth, I had some minor nits but realized we can fix them later with other bits of code.

Copy link
Copy Markdown
Contributor Author

Yup will clean them up in the other PR. Thanks! Waiting for my first merge in the repo!

nejch merged commit e5dc72d into python-gitlab:main Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for remote-import API Endpoint

2 participants


Back | FazBrowse Home | New Git URL