Repository navigation
Provide API wrapper for cherry picking commits - #236
gpocentek merged 8 commits into
Conversation
Sorry, something went wrong.
gpocentek
left a comment
There was a problem hiding this comment.
Only 2 nitpicks, but the patch looks good. Could you make the minor changes and I'll merge.
Thank you!
Sorry, something went wrong.
| :start-after: # diff | ||
| :end-before: # end diff | ||
|
|
||
| Cherry-pick a commit into another branch |
There was a problem hiding this comment.
Please end the line with a colon (:) to introduce the example.
Sorry, something went wrong.
| GitlabCherryPickError: If the cherry pick could not be applied. | ||
| """ | ||
| url = '/projects/{0:s}/repository/commits/{1:s}/cherry_pick'.format( | ||
| self.project_id, self.id) |
There was a problem hiding this comment.
For the sake of consistency could you use the old %()s format? Yes, this is nitpicking :)
Sorry, something went wrong.
There was a problem hiding this comment.
I had problems with keeping the line length below the limit of 79 characters. I worked around it now by introducing another local variable with a short name. If you have any other suggestion on how to break this string across two lines, I'd be happy to hear.
Sorry, something went wrong.
|
Thank you for this patch! |
Sorry, something went wrong.
This is a possible implementation for addressing #235. It allows to cherry pick individual commits through the Gitlab API both from the python code as well as from the command line. The documentation has been updated.