Repository navigation
Implement create pipeline API - #237
Merged
gpocentek merged 2 commits intoMar 18, 2017
Merged
gpocentek merged 2 commits into
gpocentek merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
* Integrate with BaseManager * Add doc about how to create a pipeline Reference: * https://docs.gitlab.com/ee/api/pipelines.html#create-a-new-pipeline
Copy link
Copy Markdown
Contributor
Author
|
Notes: I am not able to run tox with py27 and py34 by default. |
Sorry, something went wrong.
gpocentek
suggested changes
Mar 17, 2017
gpocentek
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Apart from a nitpick in the docs the patch looks good. If you could just do the minor update, I'll merge your change.
Thank you!
Sorry, something went wrong.
Comment thread
docs/gl_objects/projects.py
Outdated
| # pipeline create | ||
| pipeline = gl.project_pipelines.create({'project_id': 1, 'ref': 'master'}) | ||
| # or | ||
| project.pipelines.create({'ref': 'master'}) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Could you just do a minor edit for consistency:
pipeline = project.pipelines.create({'ref': 'master'})
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Sure. I have updated the document as requested |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thank you! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: