Repository navigation
feat(groups): add LDAP link manager and deprecate old API endpoints - #2379
Merged
JohnVillalovos merged 1 commit intoNov 17, 2022
Merged
JohnVillalovos merged 1 commit into
JohnVillalovos merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
nejch
force-pushed
the
feat/ldap-group-links-manager
branch
from
1afa4ce to
f6bc2a6
Compare
November 17, 2022 17:29
nejch
marked this pull request as ready for review
November 17, 2022 17:40
nejch
commented
Nov 17, 2022
Comment thread
gitlab/v4/objects/groups.py
Comment on lines
-197
to
-212
| @cli.register_custom_action("Group") | ||
| @exc.on_http_error(exc.GitlabGetError) | ||
| def list_ldap_group_links( | ||
| self, **kwargs: Any | ||
| ) -> Union[gitlab.GitlabList, List[Dict[str, Any]]]: | ||
| """List LDAP group links. | ||
|
|
||
| Args: | ||
| **kwargs: Extra options to send to the server (e.g. sudo) | ||
|
|
||
| Raises: | ||
| GitlabAuthenticationError: If authentication is not correct | ||
| GitlabGetError: If the server cannot perform the request | ||
| """ | ||
| path = f"/groups/{self.encoded_id}/ldap_group_links" | ||
| return self.manager.gitlab.http_list(path, **kwargs) |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
No deprecation needed as we haven't released it yet.
Sorry, something went wrong.
JohnVillalovos
approved these changes
Nov 17, 2022
JohnVillalovos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @nejch 🙂
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #2371.
I realized #1612 already did something similar and the list() create() delete() interface is more intuitive for the user.
Additionally, #2367 will bring in a similar interface for SAML.
And finally, the delete endpoints used in the current method are actually deprecated upstream, so good to move away from that on our side
https://docs.gitlab.com/ee/api/groups.html#delete-ldap-group-link (deprecated)
https://docs.gitlab.com/ee/api/groups.html#delete-ldap-group-link-with-cn-or-filter (new endpoint)