Wouldn't it make more sense to remove the other environments and to keep pre-commit?
pre-commit performs validations which are not covered by the granular ones.

Wouldn't it make more sense to remove the other environments and to keep pre-commit?
pre-commit performs validations which are not covered by the granular ones.

Not for me. I don't want to use pre-commit.

Wouldn't it make more sense to remove the other environments and to keep pre-commit?
pre-commit performs validations which are not covered by the granular ones.

Not for me. I don't want to use pre-commit.

John has some very strong opinions on pre-commit 😀

I also usually run a full tox locally before pushing a new PR, and also prefer the native python dependency management of that over pre-commit, at least for tests etc. I also get the full duplicate suite run now which takes a while (it used to be ~15-20 seconds IIRC).

We discussed this in #2321. I think we agreed we'd try to deduplicate this (see #2321 (reply in thread)), so I'd say the best way would be to have a tox environment that runs the missing checks only and that can be added to the default. But I'm ok to do that as a follow-up and merge this

Wouldn't it make more sense to remove the other environments and to keep pre-commit?
pre-commit performs validations which are not covered by the granular ones.

Not for me. I don't want to use pre-commit.

John has some very strong opinions on pre-commit 😀

I also usually run a full tox locally before pushing a new PR, and also prefer the native python dependency management of that over pre-commit, at least for tests etc. I also get the full duplicate suite run now which takes a while (it used to be ~15-20 seconds IIRC).

We discussed this in #2321. I think we agreed we'd try to deduplicate this (see #2321 (reply in thread)), so I'd say the best way would be to have a tox environment that runs the missing checks only and that can be added to the default. But I'm ok to do that as a follow-up and merge this

I got that @JohnVillalovos dislikes pre-commit. :-) I can't bit that with my engineering arguments.

I got that @JohnVillalovos dislikes pre-commit. :-) I can't bit that with my engineering arguments.

There's another issue with this I just realized. pre-commit keeps re-initializing on almost every run because there's always an outdated hook, which can take a while, even if the tox dependencies are otherwise up-to-date. Takes away from quick "shift left" hooks IMO, maybe let's remove it for now and find another way later.