| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Not sure if unit tests fits into test_runners.py. Could also be into test_users.py. Please tell me if I should move them. |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## main #2635 +/- ##
==========================================
+ Coverage 92.09% 96.36% +4.26%
==========================================
Files 87 87
Lines 5658 5666 +8
==========================================
+ Hits 5211 5460 +249
+ Misses 447 206 -241
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
In my opinion it should be in the test_users.py file since that is where the code is that it is testing. But otherwise this looks good to me. |
Sorry, something went wrong.
|
Hi @JohnVillalovos, and thanks for your feedback ! I moved the unit test into test_users.py , and fixed a little doc issue in my project runner creation example (which was using group_id instead of project_id). |
Sorry, something went wrong.
|
@lgatellier Thanks for the PR! Left comments to have it work like the other endpoints that use /user/*. Please let me know if you disagree with my thoughts. |
Sorry, something went wrong.
|
Thanks a lot @lgatellier @JohnVillalovos I just pushed a minor typo suggestion so that we can get this in and continue with the tasks before the next scheduled release. If you see anything else just open a follow-up :) |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Changes
This PR adds support for GitLab's new runner creation API POST /user/runners.
Closes #2606
Documentation and testing