Repository navigation
feat(api): add support for the Draft notes API - #2728
Merged
max-wittig merged 2 commits intoNov 28, 2023
Merged
max-wittig merged 2 commits into
max-wittig merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
nejch
force-pushed
the
feat/draft-notes
branch
from
3cda8ee to
9788524
Compare
November 22, 2023 15:21
Copy link
Copy Markdown
Codecov ReportAdditional details and impacted files @@ Coverage Diff @@
## main #2728 +/- ##
==========================================
+ Coverage 96.45% 96.47% +0.01%
==========================================
Files 88 89 +1
Lines 5787 5812 +25
==========================================
+ Hits 5582 5607 +25
Misses 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
max-wittig
enabled auto-merge (squash)
November 27, 2023 20:29
auto-merge was automatically disabled
November 27, 2023 20:31
Pull Request is not mergeable
nejch
force-pushed
the
feat/draft-notes
branch
from
4da940a to
a4b28b0
Compare
November 28, 2023 19:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
See https://docs.gitlab.com/ee/api/draft_notes.html
Not returning anything in the publish methods as we only get a 204 from gitlab, see below:
https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/api/draft_notes.rb#L215-261
Documentation and testing
Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated: