FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(deps): update minimum dependency versions by JohnVillalovos · Pull Request #2880 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

fix(deps): update minimum dependency versions - #2880

Merged
JohnVillalovos merged 1 commit into
mainfrom
jlvillal/use_pyproject
May 22, 2024
ConversationCommits (1)ChecksFiles changed
Merged

fix(deps): update minimum dependency versions#2880
JohnVillalovos merged 1 commit into
mainfrom
jlvillal/use_pyproject

Conversation

JohnVillalovos commented May 22, 2024

Copy link
Copy Markdown
Member

Update the minimum versions of the dependencies in the pyproject.toml file.

This is related to PR #2878

JohnVillalovos requested a review from nejch May 22, 2024 03:31
nejch approved these changes May 22, 2024
View reviewed changes

nejch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, I would just maybe change the commit type to at least fix as it's a user-facing change. Technically this could break for some people (e.g. if another dependency tracks requests with e.g. <=2.23.0 or something like that) and the dependencies will fail to resolve.

I can do this as part of the squash merge later, but I'll wait a bit in case you have feedback 👍

nejch changed the title chore: update minimum dependency versions in pyproject.toml fix: update minimum dependency versions in pyproject.toml May 22, 2024
nejch changed the title fix: update minimum dependency versions in pyproject.toml fix(deps): update minimum dependency versions May 22, 2024
JohnVillalovos force-pushed the jlvillal/use_pyproject branch from 7f38eaa to c6c1512 Compare May 22, 2024 14:02

JohnVillalovos commented May 22, 2024

Copy link
Copy Markdown
Member Author

LGTM, I would just maybe change the commit type to at least fix as it's a user-facing change. Technically this could break for some people (e.g. if another dependency tracks requests with e.g. <=2.23.0 or something like that) and the dependencies will fail to resolve.

I can do this as part of the squash merge later, but I'll wait a bit in case you have feedback 👍

Done. I updated the commit message.

Thanks.

JohnVillalovos force-pushed the jlvillal/use_pyproject branch from c6c1512 to 2df6346 Compare May 22, 2024 14:03
fix(deps): update minimum dependency versions in pyproject.toml
13ae5fd 
Update the minimum versions of the dependencies in the pyproject.toml
file.

This is related to PR #2878
JohnVillalovos force-pushed the jlvillal/use_pyproject branch from 2df6346 to 13ae5fd Compare May 22, 2024 14:35
JohnVillalovos requested a review from nejch May 22, 2024 14:35
JohnVillalovos merged commit 37b5a70 into main May 22, 2024
JohnVillalovos deleted the jlvillal/use_pyproject branch May 22, 2024 15:36

JohnVillalovos commented May 22, 2024

Copy link
Copy Markdown
Member Author

@nejch Since you had approved it, I went ahead and merged it.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nejch Awaiting requested review from nejch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL