FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix tag api by robberphex · Pull Request #307 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

Fix tag api - #307

Merged
gpocentek merged 3 commits into
python-gitlab:masterfrom
robberphex:fix-tag-api
Sep 11, 2017
ConversationCommits (3)ChecksFiles changed
Merged

Fix tag api#307
gpocentek merged 3 commits into
python-gitlab:masterfrom
robberphex:fix-tag-api

Conversation

robberphex commented Sep 11, 2017

Copy link
Copy Markdown
Contributor
  • Tag can get by id
  • on_http_error bring error_message, response_code, response_body

gpocentek reviewed Sep 11, 2017
View reviewed changes
Comment thread gitlab/v4/objects.py Outdated


class ProjectTagManager(GetFromListMixin, CreateMixin, DeleteMixin,
class ProjectTagManager(GetMixin, CreateMixin, DeleteMixin,

gpocentek Sep 11, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You could use the NoUpdateMixin instead of the 4 other mixins.

gpocentek commented Sep 11, 2017

Copy link
Copy Markdown
Contributor

Thanks!

The changes look good but you need to re-add the support for listing tags.

gpocentek merged commit fd40fce into python-gitlab:master Sep 11, 2017

gpocentek commented Sep 11, 2017

Copy link
Copy Markdown
Contributor

Thanks for the quick update!

robberphex deleted the fix-tag-api branch September 11, 2017 12:19

robberphex commented Sep 11, 2017

Copy link
Copy Markdown
Contributor Author

please release new version. currently, v1.0.0 have this bug.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
gpocentek gpocentek left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL