FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update notes api for ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager by massimiliano96 · Pull Request #3233 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

Update notes api for ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager - #3233

Merged
JohnVillalovos merged 2 commits into
python-gitlab:mainfrom
massimiliano96:update-notes-api
Jul 18, 2025
ConversationCommits (2)ChecksFiles changed
Merged

Update notes api for ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager#3233
JohnVillalovos merged 2 commits into
python-gitlab:mainfrom
massimiliano96:update-notes-api

Conversation

massimiliano96 commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

Changes

Add ListMixin to ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager

massimiliano96 mentioned this pull request Jul 18, 2025
Closed
JohnVillalovos requested a review from Copilot July 18, 2025 14:07
Copilot AI reviewed Jul 18, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

This PR updates the API for discussion note managers by replacing explicit mixin inheritance with a more concise CRUDMixin approach for both issue and merge request discussion notes.

  • Consolidates multiple explicit mixins (GetMixin, CreateMixin, UpdateMixin, DeleteMixin) into a single CRUDMixin for cleaner inheritance
  • Updates both ProjectIssueDiscussionNoteManager and ProjectMergeRequestDiscussionNoteManager classes

Comment thread gitlab/v4/objects/notes.py

codecov Bot commented Jul 18, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (be25c16) to head (15ff9d5).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3233   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          98       98           
  Lines        6058     6058           
=======================================
  Hits         5896     5896           
  Misses        162      162
Flag Coverage Δ
api_func_v4 83.69% <100.00%> (-0.05%) ⬇️
cli_func_v4 84.69% <100.00%> (ø)
unit 90.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
gitlab/v4/objects/notes.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

JohnVillalovos commented Jul 18, 2025

Copy link
Copy Markdown
Member

@massimiliano96 This looks good to me. Only suggestion is that in one of the commit messages add a Closes: #3180

So that when it gets merged the issue will get closed.

JohnVillalovos approved these changes Jul 18, 2025
View reviewed changes

JohnVillalovos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Thanks @massimiliano96

JohnVillalovos enabled auto-merge (rebase) July 18, 2025 16:15
JohnVillalovos merged commit f908f0e into python-gitlab:main Jul 18, 2025
setpill mentioned this pull request Jul 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
JohnVillalovos JohnVillalovos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL