Repository navigation
Fix all kwarg behaviour - #701
Merged
gpocentek merged 1 commit intoFeb 20, 2019
Merged
gpocentek merged 1 commit into
gpocentek merged 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
`all` kwarg is used to manage GitlabList generator behaviour. However, as it is not poped from kwargs, it is sent to Gitlab API. Some endpoints such as [the project commits](https://docs.gitlab.com/ee/api/commits.html#list-repository-commits) one, support a `all` attribute. This means a call like `project.commits.list(all=True, ref_name='master')` won't return all the master commits as one might expect but all the repository's commits. To prevent confusion, the same kwarg shouldn't be used for 2 distinct purposes. Moreover according to [the documentation](https://python-gitlab.readthedocs.io/en/stable/gl_objects/commits.html#examples), the `all` project commits API endpoint attribute doesn't seem supported.
Copy link
Copy Markdown
Member
|
Makes sense. To use the all parameter, you can supply it with query_parameters instead (starting with 1.8) |
Sorry, something went wrong.
max-wittig
reviewed
Feb 18, 2019
Comment thread
gitlab/__init__.py
max-wittig
approved these changes
Feb 18, 2019
Copy link
Copy Markdown
Member
|
@gpocentek We may need to update the documentation that all is not send to the GitLab API anymore by default. What do you think? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@max-wittig yes, we need to add that info in the release notes |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@gpocentek Could you disable the travis requirement temporary to merge this? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all kwarg is used to manage GitlabList generator behaviour.
However, as it is not pop'ed from kwargs, it is sent to Gitlab API.
Some endpoints such as the project commits one,
support a all attribute.
This means a call like project.commits.list(all=True, ref_name='master')
won't return all the master commits as one might expect but all the
repository's commits.
To prevent confusion, the same kwarg shouldn't be used for 2 distinct
purposes.
Moreover according to the documentation,
the all project commits API endpoint attribute doesn't seem supported.