Repository navigation
Make gitlab.Gitlab.from_config a classmethod - #738
Merged
gpocentek merged 1 commit intoMar 7, 2019
Merged
gpocentek merged 1 commit into
gpocentek merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gpocentek
approved these changes
Mar 7, 2019
gpocentek
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good, thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling from_config on a subclass of gitlab.Gitlab, a gitlab.Gitlab instance was returned, not the subclass.
I've changed the from_config method to a classmethod, so to return the proper class when called.
I've also added 2 tests to test "from_config".