FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Custom cli actions fix by kkoralsky · Pull Request #760 · python-gitlab/python-gitlab · GitHub

Repository navigation

Custom cli actions fix - #760

Merged
max-wittig merged 2 commits into
python-gitlab:masterfrom
kkoralsky:custom_cli_actions_fix
May 10, 2019
Merged

max-wittig merged 2 commits into
python-gitlab:masterfrom
kkoralsky:custom_cli_actions_fix

Conversation

Copy link
Copy Markdown
Contributor

run into 2 cli custom actions related issues while wokring on #759

  • *Manager custom actions (in_obj=False) ask for managed object id for example:
    • $ gitlab project-key enable --help or
    • $ gitlab runner all --help
  • *Manager custom actions (in_obj=False) dont get -/_ method name replaced

Copy link
Copy Markdown
Member

Thanks for the contribution. What do you mean with ask for managed object id for example:. I've tested your changes against master and don't see any difference in CLI output.

Copy link
Copy Markdown
Contributor Author

Basically for the first example action (gitlab project-key enable), cli would require --id and --key-id mandatory flags,

(ansdev3) koral@x270 ~/w/python-gitlab ±master⚡ » gitlab project-key enable --help
usage: gitlab project-key enable [-h] --project-id PROJECT_ID [--sudo SUDO]
                                 --id ID --key-id KEY_ID

optional arguments:
  -h, --help            show this help message and exit
  --project-id PROJECT_ID
  --sudo SUDO
  --id ID
  --key-id KEY_ID

I doubled checked if I did push all changes here is output on my branch:

(ansdev3) koral@x270 ~/w/python-gitlab ±custom_cli_actions_fix⚡ » gitlab project-key enable --help
usage: gitlab project-key enable [-h] --project-id PROJECT_ID [--sudo SUDO]
                                 --key-id KEY_ID

optional arguments:
  -h, --help            show this help message and exit
  --project-id PROJECT_ID
  --sudo SUDO
  --key-id KEY_ID

max-wittig merged commit e8823e9 into python-gitlab:master May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL