FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor: format everything black by max-wittig · Pull Request #775 · python-gitlab/python-gitlab · GitHub

Repository navigation

refactor: format everything black - #775

Merged
gpocentek merged 1 commit into
masterfrom
refactor/black
May 16, 2019
Merged

gpocentek merged 1 commit into
masterfrom
refactor/black

Conversation

Copy link
Copy Markdown
Member

Black seems to become the defacto standard for python formatting.

A lot of projects are using it already: https://github.com/python/black#used-by

Fixes #772

gpocentek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It looks like something's broken, the file creation test is failing.

Copy link
Copy Markdown
Member Author

Yes. That's because of my merge in another merge request. See my revert of it. Then I need to rebase this.

Copy link
Copy Markdown
Member Author

#776

max-wittig force-pushed the refactor/black branch 2 times, most recently from edf4adb to 18f55ea Compare May 16, 2019 16:00

Copy link
Copy Markdown
Member Author

@gpocentek Pipeline passed now.

gpocentek merged commit 290e5ed into master May 16, 2019

Copy link
Copy Markdown
Contributor

👍

max-wittig deleted the refactor/black branch May 16, 2019 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to black for code formatting

2 participants


Back | FazBrowse Home | New Git URL