FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

improve functionnal tests by jouve · Pull Request #896 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

improve functionnal tests - #896

Merged
max-wittig merged 1 commit into
python-gitlab:masterfrom
jouve:fix-functionnal-test
Oct 6, 2019
ConversationCommits (1)ChecksFiles changed
Merged

improve functionnal tests#896
max-wittig merged 1 commit into
python-gitlab:masterfrom
jouve:fix-functionnal-test

Conversation

jouve commented Oct 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • add a new flag -k to reuse the container
    • adapt python_test_v4 to be run multiple times
    • add reset_gitlab.py to undo changes made by python_test_v4
  • use gitlab container from gitlab
  • new check when gitlab is started (instead of long sleep)
  • simplify generate_token.py with requests-html

max-wittig commented Oct 6, 2019

Copy link
Copy Markdown
Member

Thank you very much @jouve. I've always wanted to improve the tests and use the GitLab container.

You may need to wait a while longer or use the healthcheck-endpoint so you can be sure that GitLab started completely.

jouve commented Oct 6, 2019

Copy link
Copy Markdown
Contributor Author

I tried the healthcheck, unfortunatelly it works on my computer by not with travis :( so I had to put the sleep 200 again

max-wittig commented Oct 6, 2019

Copy link
Copy Markdown
Member

Yeah travis is frustrating :(

max-wittig merged commit d7d2260 into python-gitlab:master Oct 6, 2019

max-wittig commented Oct 6, 2019

Copy link
Copy Markdown
Member

@jouve Thanks again!

max-wittig added a commit that referenced this pull request Oct 6, 2019
refactor: remove obsolete test image
a55fdb9 
Follow up of #896
max-wittig added a commit that referenced this pull request Oct 6, 2019
refactor: remove obsolete test image
a14c02e 
Follow up of #896
max-wittig mentioned this pull request Oct 6, 2019
Merged
max-wittig added a commit that referenced this pull request Oct 6, 2019
refactor: remove obsolete test image
a0e743a 
Follow up of #896
jouve mentioned this pull request Oct 6, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL