FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix constructing Gitlab object without authentication by jalr · Pull Request #900 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

Fix constructing Gitlab object without authentication - #900

Closed
jalr wants to merge 1 commit into
python-gitlab:masterfrom
jalr:allow-unauthenticated
ConversationCommits (1)ChecksFiles changed
Closed

Fix constructing Gitlab object without authentication#900
jalr wants to merge 1 commit into
python-gitlab:masterfrom
jalr:allow-unauthenticated

Conversation

jalr commented Oct 7, 2019

Copy link
Copy Markdown

unauthenticated access is broken since #876 was merged

fixes getting the error Only one of private_token, oauth_token or job_token should be defined when using no authentication method at all.

max-wittig commented Oct 7, 2019

Copy link
Copy Markdown
Member

Totally missed that. Thanks for the PR. Would you mind to use the commit conventions? So change to commit message to something like: fix: allow Gitlab object with auth

Thank you!

fix: constructing Gitlab object without authentication
19feb1e 
unauthenticated access is broken since #876 was merged

jalr commented Oct 7, 2019

Copy link
Copy Markdown
Author

No worries, sometimes it happens that you overlook something. I just noticed the issue today because my chat bot wasn't working anymore 😄
Just learned about the commit linter. Good idea to implement that! I hope that it passes now.

max-wittig reviewed Oct 7, 2019
View reviewed changes
Comment thread gitlab/__init__.py
for arg in [self.private_token, self.oauth_token, self.job_token]
)
!= 1
> 1

max-wittig Oct 7, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

But this does exactly the reverse. It only works, if we have multiple parameters.

We should only check this condition, if the items are larger than 1

max-wittig mentioned this pull request Oct 7, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

max-wittig max-wittig left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL