Remove redundant wheel dependency from pyproject.toml - #16
Merged
hugovk merged 1 commit intoMay 4, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The `wheel` dependency in `pyproject.toml` is not necessary, and modern setuptools documentation advises against adding it. The PEP517 backend automatically exposes the `wheel` dependency, and a future version of setuptools may no longer use it.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 9 9
Lines 635 635
=======================================
Hits 633 633
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks! A couple of references: |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wheel dependency in pyproject.toml is not necessary, and modern
setuptools documentation advises against adding it. The PEP517 backend
automatically exposes the wheel dependency, and a future version
of setuptools may no longer use it.