Fix days to hours boundary for precise delta - #19
Closed
eldipa wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…dary in precisedelta See python-humanize#14 for discussion.
for more information, see https://pre-commit.ci
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 99.68% 97.54% -2.14%
==========================================
Files 9 9
Lines 635 653 +18
==========================================
+ Hits 633 637 +4
- Misses 2 16 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks all! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14
Changes proposed in this pull request:
Note: I don't feel that truncate is the correct name and I think that it could be easily misinterpreted. We need a better name.
This PR also does not include a documentation for this flag nor tests (but a file in tests/issue-14-days-hours-boundary-in-precisedelta.md describes and tests all the cases discussed in #14 so it can be used as the base for an unit test and/or as the tests themselves running them with byexample )
Closes #14