FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve French translation by merwok · Pull Request #248 · python-humanize/humanize · GitHub

/ humanize Public

Improve French translation - #248

Merged
hugovk merged 3 commits into
python-humanize:mainfrom
merwok-forks:feat/improve-fr
Apr 1, 2025
ConversationCommits (3)ChecksFiles changed
Merged

Improve French translation#248
hugovk merged 3 commits into
python-humanize:mainfrom
merwok-forks:feat/improve-fr

Conversation

merwok commented Apr 1, 2025

Copy link
Copy Markdown
  • fix number units translations
  • use proper decimal separator

merwok commented Apr 1, 2025
View reviewed changes
Comment thread src/humanize/locale/fr_FR/LC_MESSAGES/humanize.po
msgstr "e"

#: src/humanize/number.py:178
#: src/humanize/number.py:183

merwok Apr 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In my own projects, I tend to save filenames but not line numbers to PO files, to avoid such diff churn.
What do you think of changing the update script in another PR?

hugovk Apr 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't make translations myself, so if they're not useful I'll take your word for it and a PR is welcome :)

merwok Apr 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Either the line numbers get outdated, so they are useless and get ignored, or they create churn in the history (which I could just accept but…)

So personally I find the filenames useful to be able to look up the context (source strings and even context lines from pgettext are not always enough), I tend to dislike the line numbers.

But you could open a ticket and ping translators to see their experience!

hugovk added the changelog: Fixed For any bug fixes label Apr 1, 2025

codecov Bot commented Apr 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.49%. Comparing base (09d081f) to head (4167864).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          11       11           
  Lines         796      798    +2     
=======================================
+ Hits          792      794    +2     
  Misses          4        4
Flag Coverage Δ
macos-latest 97.74% <100.00%> (+<0.01%) ⬆️
ubuntu-latest 97.74% <100.00%> (+<0.01%) ⬆️
windows-latest 95.73% <0.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hugovk merged commit f772e59 into python-humanize:main Apr 1, 2025

hugovk commented Apr 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Merci beaucoup !

merwok deleted the feat/improve-fr branch April 1, 2025 20:57
hugovk changed the title Improvements for French translation Improve French translation Apr 10, 2025
merwok commented Feb 23, 2026
View reviewed changes
Comment thread src/humanize/locale/fr_FR/LC_MESSAGES/humanize.po
msgid "thousand"
msgid_plural "thousand"
msgstr[0] "mille"
msgstr[1] "milles"

merwok Feb 23, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops I missed this. mille can take a plural mark s unless followed by other numbers. And to refer to the concept of a thousand, it should be millier or milliers. Need to check where these entries are used!

hugovk mentioned this pull request Jul 23, 2026
Closed
ckarnell mentioned this pull request Aug 17, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk left review comments

Assignees

No one assigned

Labels

changelog: Fixed For any bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL