naturaldelta: round the value to nearest unit that makes sense - #272
Merged
hugovk merged 3 commits intoDec 20, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 11 11
Lines 820 829 +9
=======================================
+ Hits 816 825 +9
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
dangillet
force-pushed
the
naturaldelta
branch
from
eeaccc3 to
e69ad3c
Compare
November 3, 2025 14:42
naturaldelta used to always round down. We want instead to round to the nearest unit that makes sense. fix python-humanize#174
dangillet
force-pushed
the
naturaldelta
branch
from
e69ad3c to
6d89dfa
Compare
November 10, 2025 15:45
hugovk
reviewed
Nov 11, 2025
Comment thread
tests/test_time.py
Outdated
We used to round down. Now we round to the nearest.
hugovk
reviewed
Dec 19, 2025
Comment thread
tests/test_time.py
Outdated
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Copy Markdown
Member
|
Thank you! |
Sorry, something went wrong.
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
naturaldelta used to always round down. We want instead to round to the nearest unit that makes sense.
Fixes #174
Changes proposed in this pull request: