Fix Spanish large number translations to use long scale - #302
Merged
hugovk merged 2 commits intoMar 24, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Spanish uses the long scale numbering system, where 'billón' means 10^12 (not 10^9 as in English). The previous translations were direct phonetic mappings from English short scale names, which are incorrect for Spanish speakers. Correct mappings (English short scale → Spanish long scale): - billion (10^9) → mil millones / miles de millones - trillion (10^12) → billón / billones - quadrillion (10^15) → mil billones / miles de billones - quintillion (10^18) → trillón / trillones - sextillion (10^21) → mil trillones / miles de trillones - septillion (10^24) → cuatrillón / cuatrillones - octillion (10^27) → mil cuatrillones / miles de cuatrillones - nonillion (10^30) → quintillón / quintillones - decillion (10^33) → mil quintillones / miles de quintillones Fixes #101
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #302 +/- ##
=======================================
Coverage 99.53% 99.53%
=======================================
Files 11 11
Lines 868 868
=======================================
Hits 864 864
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks for the PR! Please could you fix the tests? |
Sorry, something went wrong.
Update test expectations to match new long scale translations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Member
|
Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101
Problem
Spanish uses the long scale numbering system, where billón = 10^12 (not 10^9). The previous translations were phonetic mappings from English short scale names, producing incorrect output for Spanish speakers:
Correct mappings (English short scale → Spanish long scale)
Changes