FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add test for exact googol (10**100) in `intword()` by BlocksecPHD · Pull Request #304 · python-humanize/humanize · GitHub

Add test for exact googol (10**100) in intword() - #304

Merged
hugovk merged 1 commit into
python-humanize:mainfrom
BlocksecPHD:add-googol-test
Jun 30, 2026
Merged

Add test for exact googol (10**100) in intword()#304
hugovk merged 1 commit into
python-humanize:mainfrom
BlocksecPHD:add-googol-test

Conversation

BlocksecPHD commented Mar 31, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

This PR adds a test case for exact googol (10**100) in intword() function.

Context

Changes

Added test case ([10**100], "1.0 googol") to tests/test_number.py

Testing

The test passes on the current repo code (which already includes the fix from PR #273). This ensures the googol edge case is covered in the test suite for future releases.

Fixes #134

hugovk added the changelog: skip Exclude PR from release draft label Apr 1, 2026

codecov Bot commented Apr 1, 2026
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.54%. Comparing base (92b4117) to head (853e9e4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          11       11           
  Lines         871      871           
=======================================
  Hits          867      867           
  Misses          4        4           
Flag Coverage Δ
macos-latest 97.47% <ø> (ø)
ubuntu-latest 97.47% <ø> (ø)
windows-latest 95.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hugovk commented Apr 1, 2026

Copy link
Copy Markdown
Member

Testing

This test will pass once version 4.15.0 (containing the fix from PR #273) is released to PyPI.

What do you mean? It has been released: https://pypi.org/project/humanize/4.15.0/

And why does it matter if it's released to PyPI? The tests test the code in this repo.

Copy link
Copy Markdown
Contributor Author

Hi @hugovk, thank you for pointing that out! You're right - the tests test the code in this repo, not the PyPI package.

I've updated the PR description to correct that misleading statement. The test passes on the current repo code (which already has the fix from PR #273), and ensures the googol edge case is covered in the test suite.

hugovk changed the title Add test for exact googol (10**100) in intword Add test for exact googol (10**100) in intword() Jun 30, 2026
hugovk merged commit 3c577d7 into python-humanize:main Jun 30, 2026
44 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: skip Exclude PR from release draft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intword fails to parse numbers >= 1 Googol

2 participants


Back | FazBrowse Home | New Git URL