FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support Romanian ordinal formatting by lin-hongkuan · Pull Request #331 · python-humanize/humanize · GitHub

/ humanize Public

Support Romanian ordinal formatting #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lin-hongkuan wants to merge 1 commit into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 6 Commits 1 Checks 45 Files changed
Open

Support Romanian ordinal formatting #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .md  (1) .po  (1) .py  (2) All 3 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
1 change: 1 addition & 0 deletions README.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ size or throughput. It is localized to:
- Norwegian
- Persian
- Polish
- Romanian
- Russian
- Simplified Chinese
- Slovak
Expand Down
126 changes: 126 additions & 0 deletions src/humanize/locale/ro/LC_MESSAGES/humanize.po
Show comments
View file
Open in desktop

hugovk Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This file only translates src/humanize/number.py, and not the other files. Is that intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
# Romanian translations for humanize.
# This file is distributed under the same license as the humanize package.
#
msgid ""
msgstr ""
"Project-Id-Version: humanize\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2026-06-24 00:00+0000\n"
"PO-Revision-Date: 2026-06-24 00:00+0000\n"
"Last-Translator: Automatically generated\n"
"Language-Team: Romanian\n"
"Language: ro\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Plural-Forms: nplurals=3; plural=(n==1 ? 0 : (n==0 || (n%100 > 0 && n%100 < 20)) ? 1 : 2);\n"

#: src/humanize/number.py
msgctxt "ordinal value 1 (male)"
msgid "%(value)s"
msgstr "primul"

#: src/humanize/number.py
msgctxt "ordinal value 1 (female)"
msgid "%(value)s"
msgstr "prima"

#: src/humanize/number.py
msgctxt "ordinal 0 (male)"
msgid "%(value)sth"
msgstr "al %(value)s-lea"

#: src/humanize/number.py
msgctxt "ordinal 1 (male)"
msgid "%(value)sst"
msgstr "al %(value)s-lea"

#: src/humanize/number.py
msgctxt "ordinal 2 (male)"
msgid "%(value)snd"
msgstr "al %(value)s-lea"

#: src/humanize/number.py
msgctxt "ordinal 3 (male)"
msgid "%(value)srd"
msgstr "al %(value)s-lea"

#: src/humanize/number.py
msgctxt "ordinal 4 (male)"
msgid "%(value)sth"
msgstr "al %(value)s-lea"

#: src/humanize/number.py
msgctxt "ordinal 5 (male)"
msgid "%(value)sth"
msgstr "al %(value)s-lea"

#: src/humanize/number.py
msgctxt "ordinal 6 (male)"
msgid "%(value)sth"
msgstr "al %(value)s-lea"

#: src/humanize/number.py
msgctxt "ordinal 7 (male)"
msgid "%(value)sth"
msgstr "al %(value)s-lea"

#: src/humanize/number.py
msgctxt "ordinal 8 (male)"
msgid "%(value)sth"
msgstr "al %(value)s-lea"

#: src/humanize/number.py
msgctxt "ordinal 9 (male)"
msgid "%(value)sth"
msgstr "al %(value)s-lea"

#: src/humanize/number.py
msgctxt "ordinal 0 (female)"
msgid "%(value)sth"
msgstr "a %(value)s-a"

#: src/humanize/number.py
msgctxt "ordinal 1 (female)"
msgid "%(value)sst"
msgstr "a %(value)s-a"

#: src/humanize/number.py
msgctxt "ordinal 2 (female)"
msgid "%(value)snd"
msgstr "a %(value)s-a"

#: src/humanize/number.py
msgctxt "ordinal 3 (female)"
msgid "%(value)srd"
msgstr "a %(value)s-a"

#: src/humanize/number.py
msgctxt "ordinal 4 (female)"
msgid "%(value)sth"
msgstr "a %(value)s-a"

#: src/humanize/number.py
msgctxt "ordinal 5 (female)"
msgid "%(value)sth"
msgstr "a %(value)s-a"

#: src/humanize/number.py
msgctxt "ordinal 6 (female)"
msgid "%(value)sth"
msgstr "a %(value)s-a"

#: src/humanize/number.py
msgctxt "ordinal 7 (female)"
msgid "%(value)sth"
msgstr "a %(value)s-a"

#: src/humanize/number.py
msgctxt "ordinal 8 (female)"
msgid "%(value)sth"
msgstr "a %(value)s-a"

#: src/humanize/number.py
msgctxt "ordinal 9 (female)"
msgid "%(value)sth"
msgstr "a %(value)s-a"
7 changes: 6 additions & 1 deletion src/humanize/number.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
_SUPERSCRIPT_TRANS = str.maketrans(_SUPERSCRIPT_MAP)

_ORDINAL_SUFFIXES = ("th", "st", "nd", "rd", "th", "th", "th", "th", "th", "th")
_ORDINAL_VALUE = "%(value)s"
_APNUMBER_WORDS = (
"zero",
"one",
Expand Down Expand Up @@ -108,7 +109,11 @@ def ordinal(value: NumberOrString, gender: str = "male") -> str:
return str(value)
gender = "male" if gender == "male" else "female"
digit = 0 if value % 100 in (11, 12, 13) else value % 10
return f"{value}{P_(f'{digit} ({gender})', _ORDINAL_SUFFIXES[digit])}"
ordinal_format = P_(f"ordinal value {value} ({gender})", _ORDINAL_VALUE)
if ordinal_format == _ORDINAL_VALUE:
suffix = P_(f"{digit} ({gender})", _ORDINAL_SUFFIXES[digit])
ordinal_format = P_(f"ordinal {digit} ({gender})", f"{_ORDINAL_VALUE}{suffix}")
return ordinal_format % {"value": value}
Comment on lines +112 to +116

hugovk Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you explain a bit how this works? Any special instructions for the translator?


def intcomma(value: NumberOrString, ndigits: int | None = None) -> str:
Expand Down
6 changes: 6 additions & 0 deletions tests/test_i18n.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,12 @@ def test_langauge_codes(locale: str, expected_result: str) -> None:
("es_ES", 5, "female", "5ª"),
("it_IT", 3, "male", "3º"),
("it_IT", 8, "female", "8ª"),
("ro", 1, "male", "primul"),
("ro", 1, "female", "prima"),
("ro", 2, "male", "al 2-lea"),
("ro", 2, "female", "a 2-a"),
("ro", 21, "male", "al 21-lea"),
("ro", 23, "female", "a 23-a"),
],
)
def test_ordinal_genders(
Expand Down
Loading
Back | FazBrowse Home | New Git URL