fix(time): naturaldelta()/naturaltime() raise uncaught OverflowError on non-finite floats - #345
Closed
constructionusvi-create wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…on non-finite floats
for more information, see https://pre-commit.ci
Copy link
Copy Markdown
Member
|
This one is obviously complete junk, it deletes time.py. Blocking and reporting @constructionusvi-create. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
naturaldelta() and naturaltime() raise an uncaught OverflowError when passed a non-finite float (float('inf'), float('-inf')). round()/int() on a non-finite float raises OverflowError, which the except (ValueError, TypeError) clauses do not catch, so it propagates to the caller.
This guards non-finite floats explicitly: inf/-inf/nan pass through unchanged, while huge finite values still raise the documented OverflowError (unchanged).
Adds an oracle test + a disjoint held-out test.
Note: import math is placed inside the two functions to keep the diff minimal; happy to move it to the module-level import block if preferred.