fix: catch OverflowError in naturalsize() for very large integers - #355
Open
koteshyelamati wants to merge 1 commit into
Open
fix: catch OverflowError in naturalsize() for very large integers#355koteshyelamati wants to merge 1 commit into
koteshyelamati wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
naturalsize(10**309) raises OverflowError because float(value) is called unconditionally and int→float conversion overflows for very large integers. Fix: wrap float(value) in try/except (ValueError, OverflowError) and re-raise with a clear message. Reproducer: >>> import humanize >>> humanize.naturalsize(10**309) OverflowError: int too large to convert to float
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
naturalsize() calls float(value) unconditionally, which raises OverflowError for very large integers:
It also raises a raw ValueError from float() for non-numeric strings, with a confusing message.
Fix
Wrap float(value) in try/except (ValueError, OverflowError) and re-raise with a clear message indicating the argument type.
After fix