FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

prevent sensitive header value being logged by daddykotex · Pull Request #289 · python-hyper/hpack · GitHub

/ hpack Public

prevent sensitive header value being logged - #289

Merged
Kriechi merged 3 commits into
python-hyper:masterfrom
daddykotex:dfrancoeur/sensitive-headers
Mar 15, 2026
ConversationCommits (3)ChecksFiles changed
Merged

prevent sensitive header value being logged#289
Kriechi merged 3 commits into
python-hyper:masterfrom
daddykotex:dfrancoeur/sensitive-headers

Conversation

daddykotex commented Mar 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

See #288

Kriechi reviewed Mar 14, 2026
View reviewed changes
Comment thread src/hpack/hpack.py Outdated

When sensitive is True, the header value will be redacted in debug logs
and logged as "SENSITIVE_REDACTED" to prevent accidental exposure of
sensitive information.

Kriechi Mar 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please mention that this flag has a specific meaning also in the RFC. Currently an unaware user might read this sentence and assume this setting is only for logging - while in fact it has a more specific meaning on the protocol level as well.

daddykotex Mar 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

re-written as:

        When sensitive is True, the header will not be added to the header table,
        furthermore, the header value will be redacted in debug logs, as "SENSITIVE_REDACTED",
        to prevent accidental exposure of sensitive information.

Kriechi commented Mar 14, 2026

Copy link
Copy Markdown
Member

Would you mind adding a changelog entry and tests to cover the new behaviour? Thanks!

daddykotex force-pushed the dfrancoeur/sensitive-headers branch from 63513fa to b7a31bc Compare March 14, 2026 18:27
daddykotex force-pushed the dfrancoeur/sensitive-headers branch from b7a31bc to 6b99d12 Compare March 14, 2026 18:34

daddykotex commented Mar 14, 2026

Copy link
Copy Markdown
Contributor Author

Would you mind adding a changelog entry and tests to cover the new behaviour? Thanks!

Done!

daddykotex marked this pull request as ready for review March 14, 2026 18:35
Kriechi reviewed Mar 15, 2026
View reviewed changes
Comment thread src/hpack/hpack.py Outdated
Kriechi reviewed Mar 15, 2026
View reviewed changes
Comment thread CHANGELOG.rst Outdated
Kriechi merged commit 1621490 into python-hyper:master Mar 15, 2026
8 checks passed

Kriechi commented Mar 15, 2026

Copy link
Copy Markdown
Member

Thanks @daddykotex! 🎉

closes #288

daddykotex commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

Thanks again @Kriechi

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Kriechi Kriechi left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL