Check whether an EncodedURL can be decoded before giving it back - #178
Open
exarkun wants to merge 4 commits into
Open
Check whether an EncodedURL can be decoded before giving it back#178exarkun wants to merge 4 commits into
exarkun wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #153 by fixing only the Hypothesis strategy for DecodedURL. It doesn't stop encoded_urls from finding EncodedURL values which cannot be decoded by DecodedURL. It only catches these values in the decoded_urls strategy.
This might be the wrong change to make since it really only hides the fact that not all EncodedURL values can be decoded with DecodedURL. It seems like fixing the actual decoding in DecodedURL would be better, but I'm not sure how to do that.