| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@glyph sorry it took me a little bit to get back to this but went ahead and did a separate PR and just did the uplift and the py2 stuff here |
Sorry, something went wrong.
There was a problem hiding this comment.
This all looks good to me. In the future, though, please submit smaller PRs, so there's less code to look at in one big pile. Luckily most of these changes are mechanical so it wasn't that bad though — hopefully I didn't miss anything sneakily hiding in between the obvious Text → str replacements 😅
Sorry, something went wrong.
|
sigh, looks like we need to upgrade upload-artifact for this to work |
Sorry, something went wrong.
Yes I'm sorry it was larger than I had wanted there was not a good way to break this up that I had seen originally. 😅 |
Sorry, something went wrong.
I'll check this here shortly and get it updated. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Addresses #185 and uplift discussion from #189
Summary of Changes:
Open questions...
do we want to go further back to older python versions? doing so will require using containers to get old python versions (github actions only supports 3.10-3.14) but if we want to take this further back from a test perspective we could if thats critical from a code perspective i think this would work all the way back to 3.7+