clarify that received bytes are parsed by receive_data() while event-driven state changes are applied as events() is consumed
document the remote-close case explicitly in both the generated API docs and the Connection method docstrings
Why
Issue #181 points out that it is easy to assume a remote close frame moves the connection into REMOTE_CLOSING during receive_data(), when the current implementation actually performs that transition while yielding the corresponding CloseConnection event from events().
Validation
Not run locally
Relying on static review of the diff and the repository's remote CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #181 points out that it is easy to assume a remote close frame moves the connection into REMOTE_CLOSING during receive_data(), when the current implementation actually performs that transition while yielding the corresponding CloseConnection event from events().
Validation