FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Mass rename to (python-)kasa by rytilahti · Pull Request #1 · python-kasa/python-kasa · GitHub

Repository navigation

Mass rename to (python-)kasa - #1

Merged
basnijholt merged 1 commit into
masterfrom
rename_package
Dec 18, 2019
Merged

basnijholt merged 1 commit into
masterfrom
rename_package

Conversation

rytilahti commented Dec 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Member
  • Rename package to kasa. All references to pyHS100 are pointing now to either python-kasa (if it's about the project) or kasa (if it's about the package).
  • The environment variables are now prefixed with KASA_ Instead of PYHS100_.
  • cli tool is called kasa.
  • Drop python3.7 requirement for precommit hooks, not everyone will have it installed).

TODO:

  • Update README.md to describe the history of the project incl. link to pyhs100 repo.

Copy link
Copy Markdown
Contributor

LGTM 👍

The next release of Home Asssistant will be only Python 3.7.

I don't think it's unreasonable to require 3.7.

Copy link
Copy Markdown
Contributor

I'm opening and reopening to trigger CI (which broke because of the organization's name change).

basnijholt closed this Dec 18, 2019
basnijholt reopened this Dec 18, 2019

Copy link
Copy Markdown
Contributor

Merging because the failing test is unrelated to the name change.

Also in his e-mail @kirichkov said he was OK with python-kasa.

basnijholt merged commit 3ef5086 into master Dec 18, 2019
basnijholt deleted the rename_package branch December 18, 2019 08:11

Copy link
Copy Markdown
Member Author

👍 I just removed the py3.7 pinning from the pre-commit configuration, as I had only 3.8 installed locally.

I think we can move to drop support for python versions <3.7 if wanted, especially considering that even debian stable ships 3.7.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL