FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix smart led status to report rule status by sdb9696 · Pull Request #1002 · python-kasa/python-kasa · GitHub

  1. python-kasa
  2. python-kasa

Repository navigation

Fix smart led status to report rule status #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdb9696 merged 2 commits into from
Jun 23, 2024
Conversation 1 Commits 2 Checks 0 Files changed
Merged

Fix smart led status to report rule status #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6869395
Fix smart led status to report rule status
sdb9696 Jun 23, 2024
e3e5334
Merge branch 'master' into fix/smart_led
sdb9696 Jun 23, 2024
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion kasa/smart/modules/led.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def mode(self):
@property
def led(self):
"""Return current led status."""
return self.data["led_status"]
return self.data["led_rule"] != "never"

async def set_led(self, enable: bool):
"""Set led.
Expand Down
2 changes: 1 addition & 1 deletion kasa/tests/test_cli.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,7 @@ async def test_feature_set(mocker, runner):
)

led_setter.assert_called_with(True)
assert "Changing led from False to True" in res.output
assert "Changing led from True to True" in res.output
assert res.exit_code == 0


Expand Down
Back | FazBrowse Home | New Git URL