Repository navigation
Fix switching off light strip effects - #1024
Merged
rytilahti merged 1 commit intoJul 1, 2024
Merged
rytilahti merged 1 commit into
rytilahti merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## fix/effect_brightness #1024 +/- ##
=========================================================
- Coverage 91.38% 91.37% -0.01%
=========================================================
Files 84 84
Lines 5720 5716 -4
Branches 1392 1389 -3
=========================================================
- Hits 5227 5223 -4
Misses 383 383
Partials 110 110 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
rytilahti
reviewed
Jul 1, 2024
Comment thread
kasa/smart/modules/lightstripeffect.py
rytilahti
approved these changes
Jul 1, 2024
rytilahti
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM and works on L920 and L900, thanks a lot!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.