| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Back | FazBrowse Home | New Git URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityI'm not sure if we want to go that detailed here?
How do you envison short_name/long_name/brand to be used for non-smartcameras?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityActually it's the smart devices I'm thinking of with short_name long_name. The model in the device info is shorter than in the discovery info, e.g. L530 vs L530E.
In terms of the detail I'd like to replace the duplicated device specific logic that is sitting in dump_devinfo and generate_supported with this same implementation in iot and smart devices. The detail does not need to be exposed as part of the public api, that's up for discussion and I don't feel strongly.
N.B. The firmware_build is included so that when this is a property on the devices (public or private) the existing fw_version property that includes the build can get it from the DeviceInfo.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualitySounds good to me 👍
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.