FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add turnonbehaviormodule for iot by rytilahti · Pull Request #1288 · python-kasa/python-kasa · GitHub

  1. python-kasa
  2. python-kasa

Repository navigation

Add turnonbehaviormodule for iot - #1288

Draft
rytilahti wants to merge 1 commit into
masterfrom
feat/iotbulb_turnonbehavior
ConversationCommits (1)ChecksFiles changed
Draft

Add turnonbehaviormodule for iot#1288
rytilahti wants to merge 1 commit into
masterfrom
feat/iotbulb_turnonbehavior

Conversation

rytilahti commented Nov 20, 2024

Copy link
Copy Markdown
Member

A draft PR used for testing #1285.

== Configuration ==
Turn on hard (turn_on_hard): *BehaviorMode.Last* customize_preset circadian
Turn on soft (turn_on_soft): *BehaviorMode.Last* customize_preset circadian

rytilahti changed the title Migrate TurnOnBehaviours to mashumaro Add turnonbehaviormodule for iot Nov 20, 2024
rytilahti mentioned this pull request Nov 20, 2024
Merged
rytilahti force-pushed the feat/iotbulb_turnonbehavior branch from dbefbe8 to de8710b Compare November 20, 2024 14:36
rytilahti commented Nov 20, 2024
View reviewed changes
Comment thread kasa/iot/iotbulb.py
self.add_module(Module.Time, Time(self, "smartlife.iot.common.timesetting"))
self.add_module(
Module.IotTurnOnBehavior,
TurnOnBehaviorModule(self, "smartlife.iot.smartbulb.lightingservice"),

rytilahti Nov 20, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Named as Module, as TurnOnBehavior is already taken by the model... We probably want to make a breaking change here, and rename the models to something else.

github-actions Bot commented Feb 19, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

github-actions Bot added the stale label Feb 19, 2025
rytilahti added no-stale and removed stale labels Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no-stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL