FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Leverage data from UDP discovery to initialize device structure by dlee1j1 · Pull Request #132 · python-kasa/python-kasa · GitHub

  1. python-kasa
  2. python-kasa

Repository navigation

Leverage data from UDP discovery to initialize device structure - #132

Merged
rytilahti merged 6 commits into
python-kasa:masterfrom
dlee1j1:master
Feb 6, 2021
ConversationCommits (6)ChecksFiles changed
Merged

Leverage data from UDP discovery to initialize device structure#132
rytilahti merged 6 commits into
python-kasa:masterfrom
dlee1j1:master

Conversation

dlee1j1 commented Feb 5, 2021

Copy link
Copy Markdown
Contributor

Also avoids unnecessary subsequent TCP calls to device

codecov-io commented Feb 5, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #132 (4e1b1b1) into master (98b40b5) will decrease coverage by 0.03%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   73.02%   72.98%   -0.04%     
==========================================
  Files          10       10              
  Lines        1227     1229       +2     
  Branches      183      183              
==========================================
+ Hits          896      897       +1     
- Misses        298      299       +1     
  Partials       33       33
Impacted Files Coverage Δ
kasa/cli.py 54.90% <0.00%> (+0.16%) ⬆️
kasa/discover.py 40.17% <0.00%> (ø)
kasa/smartdevice.py 82.30% <33.33%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b40b5...4e1b1b1. Read the comment docs.

rytilahti reviewed Feb 5, 2021
View reviewed changes

rytilahti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a great improvement, thanks a lot! I haven't tested it personally, but it reads reasonable. Could you remove the .gitignore modification though?

Comment thread .gitignore Outdated
rytilahti approved these changes Feb 6, 2021
View reviewed changes

rytilahti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

rytilahti merged commit d4a361d into python-kasa:master Feb 6, 2021
rytilahti mentioned this pull request Feb 2, 2022
Closed
rytilahti mentioned this pull request Aug 19, 2023
Merged
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
Leverage data from UDP discovery to initialize device structure (pyth…
42bf54a 
…on-kasa#132)

* avoid talking to devices after UDP discovery

* formatting fix

* more formatting

* more formatting changes

* undo gitignore changes

* fixing git ignore for black

Co-authored-by: dlee1j1 <dlee1j@yahoo.comm>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rytilahti rytilahti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL