FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add fixture for RV30 Plus by rytilahti · Pull Request #1323 · python-kasa/python-kasa · GitHub

  1. python-kasa
  2. python-kasa

Repository navigation

Add fixture for RV30 Plus - #1323

Draft
rytilahti wants to merge 2 commits into
masterfrom
janitor/vacuum_fixtures
ConversationCommits (2)ChecksFiles changed
Draft

Add fixture for RV30 Plus#1323
rytilahti wants to merge 2 commits into
masterfrom
janitor/vacuum_fixtures

Conversation

rytilahti commented Nov 29, 2024

Copy link
Copy Markdown
Member

First vacuum fixture file, the tests won't pass until later but it's a good start.

Thanks to @steveredden for the fixture.
Dumped with #1322, related to #943 and to #937.

rytilahti added the new device New device supported due to fixture being added label Nov 29, 2024
rytilahti commented Nov 30, 2024
View reviewed changes
Comment thread devtools/dump_devinfo.py
Comment on lines +850 to +851
# Vacuum models can have a space in their name
model = model_info.long_name.replace(" ", "_")

rytilahti Nov 30, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This might break some filename parsing elsewhere, but hopefully not.. :-)

Comment thread tests/device_fixtures.py
HUBS_SMART = {"H100", "KH100"}
SENSORS_SMART = {"T310", "T315", "T300", "T100", "T110", "S200B", "S200D"}
THERMOSTATS_SMART = {"KE100"}
VACUUMS_SMART = {"RV30"}

rytilahti Nov 30, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Use the prefix, or the full name? There exist different RV30 versions in different markets, so it might be necessary to make this more strict later.

rytilahti mentioned this pull request Nov 30, 2024
Open

github-actions Bot commented Mar 1, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

github-actions Bot added the stale label Mar 1, 2025
github-actions Bot closed this Mar 9, 2025
rytilahti added no-stale and removed stale labels Mar 9, 2025
rytilahti reopened this Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

new device New device supported due to fixture being added no-stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL