FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Handle smartcam partial list responses by sdb9696 · Pull Request #1411 · python-kasa/python-kasa · GitHub

  1. python-kasa
  2. python-kasa

Repository navigation

Handle smartcam partial list responses - #1411

Merged
sdb9696 merged 2 commits into
masterfrom
feat/smartcam_lists
Jan 6, 2025
ConversationCommits (2)ChecksFiles changed
Merged

Handle smartcam partial list responses#1411
sdb9696 merged 2 commits into
masterfrom
feat/smartcam_lists

Conversation

sdb9696 commented Jan 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #1409

The H200 doesn't return smart and smartcam child devices in the same request so the SmartCamProtocol needs to be able to handle lists. The debug log in #1409 shows the H200 returning the other device type in the second request so confirmed as working.

sdb9696 mentioned this pull request Jan 3, 2025
Closed

codecov Bot commented Jan 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (361697a) to head (949d558).
Report is 79 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1411      +/-   ##
==========================================
+ Coverage   92.42%   92.52%   +0.09%     
==========================================
  Files         132      132              
  Lines        8203     8258      +55     
  Branches      839      849      +10     
==========================================
+ Hits         7582     7641      +59     
+ Misses        459      453       -6     
- Partials      162      164       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sdb9696 added the bug Something isn't working label Jan 4, 2025
sdb9696 added this to the 0.9.1 milestone Jan 4, 2025
sdb9696 marked this pull request as ready for review January 4, 2025 11:49
sdb9696 requested a review from rytilahti January 4, 2025 11:49
rytilahti approved these changes Jan 5, 2025
View reviewed changes

rytilahti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me, and works on my test device. Feel free to merge as you see fit!

Comment thread tests/fakeprotocol_smartcam.py
Comment thread tests/protocols/test_smartprotocol.py
Comment thread kasa/protocols/smartprotocol.py
sdb9696 merged commit 6aa0192 into master Jan 6, 2025
sdb9696 deleted the feat/smartcam_lists branch January 6, 2025 09:23
sdb9696 mentioned this pull request Jan 6, 2025
Merged
sdb9696 added a commit that referenced this pull request Jan 6, 2025
Prepare 0.9.1 (#1426)
40886ef 
## [0.9.1](https://github.com/python-kasa/python-kasa/tree/0.9.1) (2025-01-06)

[Full Changelog](0.9.0...0.9.1)

**Release summary:**

- Support for hub-attached wall switches S210 and S220
- Support for older firmware on Tapo cameras
- Bugfixes and improvements

**Implemented enhancements:**

- Add support for Tapo hub-attached switch devices [\#1421](#1421) (@sdb9696)
- Use repr\(\) for enum values in Feature.\_\_repr\_\_ [\#1414](#1414) (@rytilahti)
- Update SslAesTransport for older firmware versions [\#1362](#1362) (@sdb9696)

**Fixed bugs:**

- T310 not detected with H200 Hub [\#1409](#1409)
- Backoff after xor timeout and improve error reporting [\#1424](#1424) (@bdraco)
- Fix incorrect obd src echo [\#1412](#1412) (@rytilahti)
- Handle smartcam partial list responses [\#1411](#1411) (@sdb9696)

**Added support for devices:**

- Add S220 fixture [\#1419](#1419) (@rytilahti)
- Add S210 fixture [\#1418](#1418) (@rytilahti)

**Documentation updates:**

- Improve exception messages on credential mismatches [\#1417](#1417) (@rytilahti)

**Project maintenance:**

- Add C210 2.0 1.3.11 fixture [\#1406](#1406) (@sdb9696)
- Add HS210\(US\) 3.0 1.0.10 IOT Fixture [\#1405](#1405) (@ZeliardM)
- Change smartcam detection features to category config [\#1402](#1402) (@sdb9696)
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025
Handle smartcam partial list responses (python-kasa#1411)
1d3b6cf
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025
Prepare 0.9.1 (python-kasa#1426)
2fcbf7e 
## [0.9.1](https://github.com/python-kasa/python-kasa/tree/0.9.1) (2025-01-06)

[Full Changelog](python-kasa/python-kasa@0.9.0...0.9.1)

**Release summary:**

- Support for hub-attached wall switches S210 and S220
- Support for older firmware on Tapo cameras
- Bugfixes and improvements

**Implemented enhancements:**

- Add support for Tapo hub-attached switch devices [\python-kasa#1421](python-kasa#1421) (@sdb9696)
- Use repr\(\) for enum values in Feature.\_\_repr\_\_ [\python-kasa#1414](python-kasa#1414) (@rytilahti)
- Update SslAesTransport for older firmware versions [\python-kasa#1362](python-kasa#1362) (@sdb9696)

**Fixed bugs:**

- T310 not detected with H200 Hub [\python-kasa#1409](python-kasa#1409)
- Backoff after xor timeout and improve error reporting [\python-kasa#1424](python-kasa#1424) (@bdraco)
- Fix incorrect obd src echo [\python-kasa#1412](python-kasa#1412) (@rytilahti)
- Handle smartcam partial list responses [\python-kasa#1411](python-kasa#1411) (@sdb9696)

**Added support for devices:**

- Add S220 fixture [\python-kasa#1419](python-kasa#1419) (@rytilahti)
- Add S210 fixture [\python-kasa#1418](python-kasa#1418) (@rytilahti)

**Documentation updates:**

- Improve exception messages on credential mismatches [\python-kasa#1417](python-kasa#1417) (@rytilahti)

**Project maintenance:**

- Add C210 2.0 1.3.11 fixture [\python-kasa#1406](python-kasa#1406) (@sdb9696)
- Add HS210\(US\) 3.0 1.0.10 IOT Fixture [\python-kasa#1405](python-kasa#1405) (@ZeliardM)
- Change smartcam detection features to category config [\python-kasa#1402](python-kasa#1402) (@sdb9696)
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025
Handle smartcam partial list responses (python-kasa#1411)
cb41c9e
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025
Prepare 0.9.1 (python-kasa#1426)
ee2ce92 
## [0.9.1](https://github.com/python-kasa/python-kasa/tree/0.9.1) (2025-01-06)

[Full Changelog](python-kasa/python-kasa@0.9.0...0.9.1)

**Release summary:**

- Support for hub-attached wall switches S210 and S220
- Support for older firmware on Tapo cameras
- Bugfixes and improvements

**Implemented enhancements:**

- Add support for Tapo hub-attached switch devices [\python-kasa#1421](python-kasa#1421) (@sdb9696)
- Use repr\(\) for enum values in Feature.\_\_repr\_\_ [\python-kasa#1414](python-kasa#1414) (@rytilahti)
- Update SslAesTransport for older firmware versions [\python-kasa#1362](python-kasa#1362) (@sdb9696)

**Fixed bugs:**

- T310 not detected with H200 Hub [\python-kasa#1409](python-kasa#1409)
- Backoff after xor timeout and improve error reporting [\python-kasa#1424](python-kasa#1424) (@bdraco)
- Fix incorrect obd src echo [\python-kasa#1412](python-kasa#1412) (@rytilahti)
- Handle smartcam partial list responses [\python-kasa#1411](python-kasa#1411) (@sdb9696)

**Added support for devices:**

- Add S220 fixture [\python-kasa#1419](python-kasa#1419) (@rytilahti)
- Add S210 fixture [\python-kasa#1418](python-kasa#1418) (@rytilahti)

**Documentation updates:**

- Improve exception messages on credential mismatches [\python-kasa#1417](python-kasa#1417) (@rytilahti)

**Project maintenance:**

- Add C210 2.0 1.3.11 fixture [\python-kasa#1406](python-kasa#1406) (@sdb9696)
- Add HS210\(US\) 3.0 1.0.10 IOT Fixture [\python-kasa#1405](python-kasa#1405) (@ZeliardM)
- Change smartcam detection features to category config [\python-kasa#1402](python-kasa#1402) (@sdb9696)
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025
Handle smartcam partial list responses (python-kasa#1411)
44c12a5
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025
Prepare 0.9.1 (python-kasa#1426)
57a85f2 
## [0.9.1](https://github.com/python-kasa/python-kasa/tree/0.9.1) (2025-01-06)

[Full Changelog](python-kasa/python-kasa@0.9.0...0.9.1)

**Release summary:**

- Support for hub-attached wall switches S210 and S220
- Support for older firmware on Tapo cameras
- Bugfixes and improvements

**Implemented enhancements:**

- Add support for Tapo hub-attached switch devices [\python-kasa#1421](python-kasa#1421) (@sdb9696)
- Use repr\(\) for enum values in Feature.\_\_repr\_\_ [\python-kasa#1414](python-kasa#1414) (@rytilahti)
- Update SslAesTransport for older firmware versions [\python-kasa#1362](python-kasa#1362) (@sdb9696)

**Fixed bugs:**

- T310 not detected with H200 Hub [\python-kasa#1409](python-kasa#1409)
- Backoff after xor timeout and improve error reporting [\python-kasa#1424](python-kasa#1424) (@bdraco)
- Fix incorrect obd src echo [\python-kasa#1412](python-kasa#1412) (@rytilahti)
- Handle smartcam partial list responses [\python-kasa#1411](python-kasa#1411) (@sdb9696)

**Added support for devices:**

- Add S220 fixture [\python-kasa#1419](python-kasa#1419) (@rytilahti)
- Add S210 fixture [\python-kasa#1418](python-kasa#1418) (@rytilahti)

**Documentation updates:**

- Improve exception messages on credential mismatches [\python-kasa#1417](python-kasa#1417) (@rytilahti)

**Project maintenance:**

- Add C210 2.0 1.3.11 fixture [\python-kasa#1406](python-kasa#1406) (@sdb9696)
- Add HS210\(US\) 3.0 1.0.10 IOT Fixture [\python-kasa#1405](python-kasa#1405) (@ZeliardM)
- Change smartcam detection features to category config [\python-kasa#1402](python-kasa#1402) (@sdb9696)
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Jul 5, 2026
Handle smartcam partial list responses (python-kasa#1411)
4996d9a
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Jul 5, 2026
Prepare 0.9.1 (python-kasa#1426)
87248dc 
## [0.9.1](https://github.com/python-kasa/python-kasa/tree/0.9.1) (2025-01-06)

[Full Changelog](python-kasa/python-kasa@0.9.0...0.9.1)

**Release summary:**

- Support for hub-attached wall switches S210 and S220
- Support for older firmware on Tapo cameras
- Bugfixes and improvements

**Implemented enhancements:**

- Add support for Tapo hub-attached switch devices [\python-kasa#1421](python-kasa#1421) (@sdb9696)
- Use repr\(\) for enum values in Feature.\_\_repr\_\_ [\python-kasa#1414](python-kasa#1414) (@rytilahti)
- Update SslAesTransport for older firmware versions [\python-kasa#1362](python-kasa#1362) (@sdb9696)

**Fixed bugs:**

- T310 not detected with H200 Hub [\python-kasa#1409](python-kasa#1409)
- Backoff after xor timeout and improve error reporting [\python-kasa#1424](python-kasa#1424) (@bdraco)
- Fix incorrect obd src echo [\python-kasa#1412](python-kasa#1412) (@rytilahti)
- Handle smartcam partial list responses [\python-kasa#1411](python-kasa#1411) (@sdb9696)

**Added support for devices:**

- Add S220 fixture [\python-kasa#1419](python-kasa#1419) (@rytilahti)
- Add S210 fixture [\python-kasa#1418](python-kasa#1418) (@rytilahti)

**Documentation updates:**

- Improve exception messages on credential mismatches [\python-kasa#1417](python-kasa#1417) (@rytilahti)

**Project maintenance:**

- Add C210 2.0 1.3.11 fixture [\python-kasa#1406](python-kasa#1406) (@sdb9696)
- Add HS210\(US\) 3.0 1.0.10 IOT Fixture [\python-kasa#1405](python-kasa#1405) (@ZeliardM)
- Change smartcam detection features to category config [\python-kasa#1402](python-kasa#1402) (@sdb9696)
vanpuyveldesimon-design mentioned this pull request Oct 17, 2026
Open
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
Handle smartcam partial list responses (python-kasa#1411)
11d8a48
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
Prepare 0.9.1 (python-kasa#1426)
013b9dc 
## [0.9.1](https://github.com/python-kasa/python-kasa/tree/0.9.1) (2025-01-06)

[Full Changelog](python-kasa/python-kasa@0.9.0...0.9.1)

**Release summary:**

- Support for hub-attached wall switches S210 and S220
- Support for older firmware on Tapo cameras
- Bugfixes and improvements

**Implemented enhancements:**

- Add support for Tapo hub-attached switch devices [\python-kasa#1421](python-kasa#1421) (@sdb9696)
- Use repr\(\) for enum values in Feature.\_\_repr\_\_ [\python-kasa#1414](python-kasa#1414) (@rytilahti)
- Update SslAesTransport for older firmware versions [\python-kasa#1362](python-kasa#1362) (@sdb9696)

**Fixed bugs:**

- T310 not detected with H200 Hub [\python-kasa#1409](python-kasa#1409)
- Backoff after xor timeout and improve error reporting [\python-kasa#1424](python-kasa#1424) (@bdraco)
- Fix incorrect obd src echo [\python-kasa#1412](python-kasa#1412) (@rytilahti)
- Handle smartcam partial list responses [\python-kasa#1411](python-kasa#1411) (@sdb9696)

**Added support for devices:**

- Add S220 fixture [\python-kasa#1419](python-kasa#1419) (@rytilahti)
- Add S210 fixture [\python-kasa#1418](python-kasa#1418) (@rytilahti)

**Documentation updates:**

- Improve exception messages on credential mismatches [\python-kasa#1417](python-kasa#1417) (@rytilahti)

**Project maintenance:**

- Add C210 2.0 1.3.11 fixture [\python-kasa#1406](python-kasa#1406) (@sdb9696)
- Add HS210\(US\) 3.0 1.0.10 IOT Fixture [\python-kasa#1405](python-kasa#1405) (@ZeliardM)
- Change smartcam detection features to category config [\python-kasa#1402](python-kasa#1402) (@sdb9696)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rytilahti rytilahti approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

T310 not detected with H200 Hub

2 participants

Back | FazBrowse Home | New Git URL