Codecov Report

Merging #149 (7f08895) into master (2fe1b20) will increase coverage by 0.27%.
The diff coverage is 67.85%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   73.24%   73.51%   +0.27%     
==========================================
  Files          11       11              
  Lines        1241     1265      +24     
  Branches      183      186       +3     
==========================================
+ Hits          909      930      +21     
  Misses        299      299              
- Partials       33       36       +3     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fe1b20...7f08895. Read the comment docs.

Codecov Report

Merging #149 (c53abc9) into master (bcb9fe1) will decrease coverage by 0.55%.
The diff coverage is 61.40%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   82.15%   81.60%   -0.56%     
==========================================
  Files          12       12              
  Lines        1317     1348      +31     
  Branches      195      202       +7     
==========================================
+ Hits         1082     1100      +18     
- Misses        196      206      +10     
- Partials       39       42       +3     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb9fe1...c53abc9. Read the comment docs.

Hi, thanks for the PR & sorry for the delay! I did a brief review and added some comments inline. Just as a side note, my KP303 works with the current IDs just fine.

Mine works with the pykasa cli because it grabs get_sysinfo from the direct TCP call. That one returns the full child ID (with the parent ID pre-pended). I found this problem in my Home Assistant branch which avoids that TCP call by pulling in the sysinfo data from the discovery call.

I also added a new CLI option to set the state of the device using discovery info. That allows you to test with the actual device. You can try to see if your KP400 has the same behavior as mine by filling the data with --use_discovery then trying to set the state one of the plugs.

If I back out the exception code in SmartStrip.py it fails for mine.

To my understanding this has been fixed through other means & there has been many, many changes to how the devices are initialized, so I think we can close this now. If there are still issues with these, it probably makes sense to fix those in a separate PR anyway :-)