Repository navigation
Add support for plugs with emeters. - #154
brendandburns wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
Look like linting is failing, I will try to correct it. |
Sorry, something went wrong.
kirichkov
left a comment
There was a problem hiding this comment.
Also the linting errors need to be addressed. Otherwise it looks good to me. I'd appreciate a review from @rytilahti as I haven't looked into the HS300 code.
Sorry, something went wrong.
| emeter_rt[field] += value | ||
|
|
||
| # Voltage is averaged | ||
| emeter_rt['voltage_mv'] /= count |
There was a problem hiding this comment.
I get the idea here, but have you ever noticed the individual plugs reporting different voltage? Normally you should get the same voltage from each child-plug.
Sorry, something went wrong.
| emeter_rt: DefaultDict[int, float] = defaultdict(lambda: 0.0) | ||
| count = 0 | ||
| for plug in self.children: | ||
| if not plug.has_emeter: |
There was a problem hiding this comment.
Is this a real-world case, where some sockets on the same strip have and some sockets don't have emeter? If not I think this would be redundant
Sorry, something went wrong.
|
Testing with changes: import asyncio
from kasa import SmartStrip
strip = SmartStrip("172.25.100.114")
asyncio.run(strip.update())
print(strip.alias)
for plug in strip.children:
print(f"{plug.alias}: {plug.emeter_realtime}")
Output shows same data for each plug, unlike the app. ubuntu@ubuntu:~/working/kasa-pull$ python3 kasa-pull.py
TP-LINK_Power Strip_0C50
Hi CMH 01: {'voltage_mv': 119151, 'current_ma': 3, 'power_mw': 6, 'total_wh': 47924, 'err_code': 0}
Lo CMH 01: {'voltage_mv': 119151, 'current_ma': 3, 'power_mw': 6, 'total_wh': 47924, 'err_code': 0}
Irrigation Pump: {'voltage_mv': 119151, 'current_ma': 3, 'power_mw': 6, 'total_wh': 47924, 'err_code': 0}
Exhaust Fan: {'voltage_mv': 119151, 'current_ma': 3, 'power_mw': 6, 'total_wh': 47924, 'err_code': 0}
LED: {'voltage_mv': 119151, 'current_ma': 3, 'power_mw': 6, 'total_wh': 47924, 'err_code': 0}
Sump Pump: {'voltage_mv': 119151, 'current_ma': 3, 'power_mw': 6, 'total_wh': 47924, 'err_code': 0}
I am guessing this isn't the expected behavior? |
Sorry, something went wrong.
|
Just wanted to say that it would be great to see kasa officially support tplink powerstrips with emeters. I don't have mine yet, but from the looks of the last comment, it's not reporting real time data correctly. |
Sorry, something went wrong.
|
Last I checked it didn't report any emeter data.
On Sep 7, 2021 9:44 AM, Einsteinjr84 ***@***.***> wrote:
Just wanted to say that it would be great to see kasa officially support tplink powerstrips with emeters. I don't have mine yet, but from the looks of the last comment, it's not reporting real time data correctly.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#154 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJAXMXWYI7ITTI6DAGLVLCTUAYQNFANCNFSM42NCXWSA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sorry, something went wrong.
Looks like the PR has gone stale, so you'd need to manually add the changes from the PR to your local codebase to test it. Unfortunately we don't have the device at all in Europe, so people who have the device (I think it's available only in the US) should provide at minimum a json dump and do the real-world testing. |
Sorry, something went wrong.
|
Superseded by #203, thanks for the PR though :-) |
Sorry, something went wrong.
This fixes #64