FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added KL125 and HS200 fixture dumps and updated tests to run on new format by brianthedavis · Pull Request #160 · python-kasa/python-kasa · GitHub

  1. python-kasa
  2. python-kasa

Repository navigation

Added KL125 and HS200 fixture dumps and updated tests to run on new format - #160

Merged
rytilahti merged 3 commits into
python-kasa:masterfrom
brianthedavis:added_new_fixtures_from_dump_devinfo
May 11, 2021
ConversationCommits (3)ChecksFiles changed
Merged

Added KL125 and HS200 fixture dumps and updated tests to run on new format#160
rytilahti merged 3 commits into
python-kasa:masterfrom
brianthedavis:added_new_fixtures_from_dump_devinfo

Conversation

brianthedavis commented May 11, 2021

Copy link
Copy Markdown
Contributor
  • Added KL125 1.20 color bulb fixture
  • Added HS200 5.0 wall switch fixture
  • Updated the conftest.py to automatically include any COLOR_BULBS or VARIABLE_TEMP bulbs in the BULBS device set (I spent a good 10 minutes scratching my head on why I couldn't get this to work until I realized the convention used....this seems to make more sense to not accidentally omit a device type)
  • Added a check within newfakes.py to safely skip over the emeter key if it's not in the fixture dump (which it's not on the new fixtures added)

codecov-commenter commented May 11, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #160 (5bb6700) into master (0471e1a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   74.42%   74.42%           
=======================================
  Files          11       11           
  Lines        1220     1220           
  Branches      177      177           
=======================================
  Hits          908      908           
  Misses        279      279           
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0471e1a...5bb6700. Read the comment docs.

brianthedavis mentioned this pull request May 11, 2021
Closed
rytilahti approved these changes May 11, 2021
View reviewed changes

rytilahti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, thanks! 👍

rytilahti merged commit 28a902c into python-kasa:master May 11, 2021
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
Added KL125 and HS200 fixture dumps and updated tests to run on new f…
d3a8b0f 
…ormat (python-kasa#160)

* Added new fixtures

* Refactored bulb categories and check for emeter on run

* linting changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rytilahti rytilahti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL