FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix camera login version in CLI by ZeliardM · Pull Request #1658 · python-kasa/python-kasa · GitHub

Repository navigation

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
1 change: 0 additions & 1 deletion kasa/cli/main.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,6 @@ async def cli(
if type == "camera":
encrypt_type = "AES"
https = True
login_version = 2
device_family = "SMART.IPCAMERA"

from kasa.device import Device
Expand Down
37 changes: 37 additions & 0 deletions tests/test_cli.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -1039,6 +1039,43 @@ async def _state(dev: Device):
assert isinstance(result_device, expected_type)


@pytest.mark.parametrize(
("cli_login_version", "expected_login_version"),
[
pytest.param(None, 2, id="No login-version defaults to 2"),
pytest.param(3, 3, id="Explicit login-version 3 is preserved"),
pytest.param(2, 2, id="Explicit login-version 2 is preserved"),
],
)
async def test_type_camera_login_version(
cli_login_version, expected_login_version, mocker, runner
):
"""Test that --type camera respects an explicitly provided --login-version."""
from kasa.deviceconfig import DeviceConfig

captured_config: DeviceConfig | None = None

mocker.patch("kasa.cli.device.state")

async def _mock_connect(config: DeviceConfig):
nonlocal captured_config
captured_config = config
dev = SmartCamDevice(host="127.0.0.1", config=config)
return dev

mocker.patch("kasa.device.Device.connect", side_effect=_mock_connect)
mocker.patch.object(SmartCamDevice, "update")

args = ["--type", "camera", "--host", "127.0.0.1"]
if cli_login_version is not None:
args += ["--login-version", str(cli_login_version)]

res = await runner.invoke(cli, args)
assert res.exit_code == 0, res.output
assert captured_config is not None
assert captured_config.connection_type.login_version == expected_login_version


@pytest.mark.skip(
"Skip until pytest-asyncio supports pytest 8.0, https://github.com/pytest-dev/pytest-asyncio/issues/737"
)
Expand Down

Back | FazBrowse Home | New Git URL