| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Use KlapTransportV2 for IOT KLAP devices with login_version >= 2 and derive IOT plug/switch+b ulb classes from get_sysinfo so strips are not misclassified as plugs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1692 +/- ##
=======================================
Coverage 93.22% 93.22%
=======================================
Files 157 157
Lines 9815 9817 +2
Branches 1003 1004 +1
=======================================
+ Hits 9150 9152 +2
Misses 472 472
Partials 193 193 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
There was a problem hiding this comment.
Fixes regressions affecting IOT devices using KLAP on newer firmware by selecting the correct KLAP transport for login v2 and ensuring correct device-class instantiation (e.g., strips vs plugs) based on system.get_sysinfo during connect().
Changes:
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kasa/device_factory.py | Adjusts IOT connect path to derive class from sysinfo for plugs/bulbs and selects KlapTransportV2 for IOT KLAP login v2. |
| tests/test_device_factory.py | Adds tests asserting IOT KLAP login v2 uses KlapTransportV2 and that KLAP strips are instantiated via sysinfo detection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
|
✅ Independently confirmed this fix works on real hardware. I hit this exact bug on an HS103 (US) HW 5.0, FW 1.1.3 Build 250908 running on Home Assistant 2026.5.4 (python-kasa 0.10.2). Device reports with in discovery, but mapped it to (v1, MD5) — causing . I independently arrived at the same fix (upgrading to when ) before finding this PR. Validated by:
This is blocking real HA users — anyone with HS103/HS200/HS300/KP303 on newer firmware (HW 5.0+) can't add these devices. The fix is minimal, correct, and well-tested. Would love to see this merged. 🚀 |
Sorry, something went wrong.
|
Hey Brad! Another Brad here confirming this against real hardware. I hit the same failure path in Home Assistant with a TP-Link HS103:
Before applying this patch, Home Assistant/python-kasa selected the normal KlapTransport path for IOT.KLAP and failed during handshake1: Finding protocol for 192.168.5.241
Finding transport for IOT.KLAP
Created KLAP transport for 192.168.5.241
Handshake1 success ... Response status is 200
Device response did not match our challenge on ip 192.168.5.241
I applied the same selection logic from this PR inside the HA container and restarted HA. A direct transport-selection probe then showed: login_version None -> KlapTransport
login_version 1 -> KlapTransport
login_version 2 -> KlapTransportV2
After that, the HS103 began authenticating/querying successfully from Home Assistant: Device 192.168.5.241 query posted ... Response status is 200
Device 192.168.5.241 query response received
Finished fetching 192.168.5.241 data ... success: True
So this is another confirmation that IOT KLAP devices advertising lv: 2 / new_klap: 1 need KlapTransportV2; otherwise valid TP-Link credentials fail with the challenge mismatch. This PR is the minimal fix for the behavior I observed. |
Sorry, something went wrong.
There was a problem hiding this comment.
Reviewed and tested.
LGTM -- recommend merging.
Sorry, something went wrong.
|
I independently validated this failure and the two-part fix against a real HS300 power strip through Home Assistant. Environment and device:
Stock HA / python-kasa 0.10.2 failed immediately during reauth with valid TP-Link credentials: Device response did not match our challenge
A direct KLAP v2 handshake succeeded with the same credentials, and IotProtocol + KlapTransportV2 was able to query the device successfully. I then patched HA's vendored integration locally with the same two behavioral changes as this PR:
After restarting HA, the reconfigure flow completed successfully and the config entry stored the credential hash. The sysinfo/class-detection part was also required: without that path, this HS300 gets treated as a generic IotPlug, losing the strip children. With both parts of the fix in place, HA created the strip plus all child outlets and energy/voltage sensors as available. So this PR matches the fix required for HS300 as well as the HS103 confirmations above: the transport change fixes auth, and the sysinfo class detection fixes child outlet/entity creation for strips. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGMT
Sorry, something went wrong.
|
There is already an existing, extensively tested PR that handles all of the CLI and API changes, #1580, we are working to get this implemented and a new version released soon. |
Sorry, something went wrong.
|
Adding KP303 power-strip evidence for the two changes in this PR, also relevant to #1580. On 2026-09-02 I upgraded Home Assistant Core from 2026.7.2 to 2026.8.3, retaining a local backport on python-kasa 0.10.2 that:
After replacing the HA container and restarting, the real KP303 parent and all three child outlets were still present. The outlet states remained one ON and two OFF, matching the pre-upgrade snapshot; none of those outlets became unavailable. The candidate image also passed isolated checks with networking disabled: login version 1 selects KlapTransport, version 2 selects KlapTransportV2, and a get_sysinfo response containing children resolves to IotStrip. Scope: this is evidence for an equivalent local backport and its HA restart/upgrade behavior, not a test of the complete #1692 or #1580 branch. The isolated class test calls the sysinfo class resolver, not the full connect() path. I did not issue physical outlet-toggle commands during this maintenance check, and I have not captured hardware/firmware revisions for this report. |
Sorry, something went wrong.
|
I tried using this change for 2 of my HS200 that I updated and that stopped responding, it didn't work. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
This PR fixes two related regressions for IOT KLAP devices on newer firmware:
Why
Tests