FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Build and check packages in CI and publish workflows by rytilahti · Pull Request #1782 · python-kasa/python-kasa · GitHub

  1. python-kasa
  2. python-kasa

Repository navigation

Build and check packages in CI and publish workflows - #1782

Merged
rytilahti merged 1 commit into
masterfrom
ci/check-packaging
Oct 9, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Build and check packages in CI and publish workflows#1782
rytilahti merged 1 commit into
masterfrom
ci/check-packaging

Conversation

rytilahti commented Oct 4, 2026

Copy link
Copy Markdown
Member

The 0.11.0 upload failed only after the release was tagged and published, which burned the version number due to immutable releases (see #1779).

  • Add a local build-packages action that builds the packages with the release build constraints and runs twine check --strict on them.
  • Run it in the lint job, so packaging issues are caught on every PR before anything is tagged.
  • Use the same action in the publish workflow, and disable the publish action's own metadata check, so the check before upload is identical to the one in CI and twine is pinned in a single place.

Build and check packages in CI and publish workflows
26333e9 
Share one action for building and verifying the release artifacts,
so packaging issues like the one that broke the 0.11.0 upload are caught on every PR,
and the check before upload is the same one CI runs.
rytilahti added the maintenance Project improvements and maintenance label Oct 4, 2026
rytilahti requested a review from ZeliardM October 4, 2026 19:03
ZeliardM approved these changes Oct 4, 2026
View reviewed changes

ZeliardM left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Excellent idea, great catch!

codecov Bot commented Oct 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.41%. Comparing base (ff26187) to head (26333e9).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1782   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files         159      159           
  Lines       10113    10113           
  Branches     1043     1043           
=======================================
  Hits         9447     9447           
  Misses        472      472           
  Partials      194      194

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rytilahti merged commit 38a3184 into master Oct 9, 2026
22 checks passed
rytilahti deleted the ci/check-packaging branch October 9, 2026 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeliardM ZeliardM approved these changes

Assignees

No one assigned

Labels

maintenance Project improvements and maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL