Repository navigation
Add speaker talkback to smartcam Camera module - #1784
Open
juherr wants to merge 4 commits into
Open
juherr wants to merge 4 commits into
juherr wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
kasa/smartcam/media.py
|
|
||
|
|
||
| def _md5_hex(value: str) -> str: | ||
| return hashlib.md5(value.encode()).hexdigest() # noqa: S324 |
Comment thread
kasa/smartcam/media.py
| def _digest_password(cloud_password: str, encrypt_type: str | None) -> str: | ||
| """Return the camera media password derived from the cloud password.""" | ||
| hash_func = hashlib.sha256 if encrypt_type == "3" else hashlib.md5 | ||
| return hash_func(cloud_password.encode()).hexdigest().upper() |
Comment thread
tests/smartcam/test_media.py
| [ | ||
| pytest.param( | ||
| ', encrypt_type="3"', | ||
| hashlib.sha256(PASSWORD.encode()).hexdigest().upper(), |
Comment thread
tests/smartcam/test_media.py
| ), | ||
| pytest.param( | ||
| "", | ||
| hashlib.md5(PASSWORD.encode()).hexdigest().upper(), # noqa: S324 |
Comment thread
tests/smartcam/test_media.py
| ), | ||
| pytest.param( | ||
| ', encrypt_type="2"', | ||
| hashlib.md5(PASSWORD.encode()).hexdigest().upper(), # noqa: S324 |
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1784 +/- ##
==========================================
+ Coverage 93.41% 93.58% +0.17%
==========================================
Files 159 161 +2
Lines 10113 10390 +277
Branches 1043 1076 +33
==========================================
+ Hits 9447 9724 +277
Misses 472 472
Partials 194 194 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds speaker-only talkback for Tapo cameras, the first step proposed in #1763.
audio_stream must already be encoded as G.711 A-law (PCMA), 8 kHz, mono, raw bytes (8000 bytes = 1 s).
python-kasa does no decoding, resampling or transcoding; the caller (e.g. Home Assistant with FFmpeg)
produces the camera-compatible audio. There are no new dependencies.
The call returns when the input is exhausted and its playback time has elapsed. Cancelling the task stops
playback and closes the session. Only one playback per camera can be active; a second call raises
KasaException. The camera never acknowledges playback, so returning does not guarantee the audio was heard.
Implementation
The camera media server is a second connection, separate from the management API, so it is not a
BaseTransport:
from the challenge's encrypt_type
0x90, PID 0x100)
handling. It rejects hub children, devices without the audio component, and missing credentials
(AuthenticationError).
Notes on the sending side:
absolute monotonic schedule, independent of the caller's chunk sizes. The schedule restarts instead of
bursting if the producer stalls.
rate.
The protocol follows go2rtc's pkg/tapo and was
checked against a C200. Microphone/preview, codec negotiation and other codecs are out of scope.
Tests
Tests are deterministic, with no sockets and a fake clock. They cover:
The generated stream was also checked with ffprobe.
Hardware validation
Tested on a Tapo C200 (HW 1.0, FW 1.3.17 Build 260112) over Wi-Fi (RSSI -55 dBm), client wired.
Audio was raw PCMA 8 kHz mono, generated tones and a macOS TTS sample converted with
ffmpeg -ar 8000 -ac 1 -f alaw.
Observations:
previous one ended.
camera-side TCP latency spikes (median RTT ~10 ms, peaks ~330–380 ms, no retransmissions; ~4 spikes per
10 s idle, ~9 with live view).
burst caused retransmissions), so strict real-time pacing is kept.
@rytilahti I haven't tested on a TC65 yet. If you can try it with yours, that would help; a small test script
is available on request.
Part of #1763.
Development of this PR was driven by Claude AI. I reviewed the changes and validated them on the hardware above.