Repository navigation
Handle hubs that omit the child list when they have no children - #1785
Open
IDavinciCode wants to merge 1 commit into
Open
IDavinciCode wants to merge 1 commit into
IDavinciCode wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
An H200 or H500 hub without paired children answers getChildDeviceList and getChildDeviceComponentList with only start_index and sum. The pagination helper then called next() on an empty iterator, which inside a coroutine surfaces as "RuntimeError: coroutine raised StopIteration" and aborts setup. Return early when no list is present, and read the child lists with a default where the code indexed them directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1785 +/- ##
=======================================
Coverage 93.41% 93.41%
=======================================
Files 159 159
Lines 10113 10115 +2
Branches 1043 1044 +1
=======================================
+ Hits 9447 9449 +2
Misses 472 472
Partials 194 194 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An H200 (or H500) hub without paired children answers
getChildDeviceList / getChildDeviceComponentList with only
start_index and sum, no list. _handle_response_lists then calls
next() on an empty iterator, which inside a coroutine becomes
RuntimeError: coroutine raised StopIteration and aborts setup in
Home Assistant.
with a default instead of indexing them, so the list-less response is
treated as "no children" (smart and smartcam).
This is the change proposed in the issue by a user who confirmed it on an
empty hub; with children present the behaviour is unchanged.
Tests:
StopIteration from the issue on master.
omitted and asserts no error is logged; on master all 9 hub fixtures fail.
Fixes #1728
Related: #1773 (same traceback on an H500)
🤖 Generated with Claude Code