FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Consolidate SSL ciphers and use them in SslTransport by rytilahti · Pull Request #1798 · python-kasa/python-kasa · GitHub

  1. python-kasa
  2. python-kasa

Repository navigation

Consolidate SSL ciphers and use them in SslTransport - #1798

Merged
rytilahti merged 1 commit into
python-kasa:masterfrom
rytilahti:fix/rv10_ssl
Oct 14, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Consolidate SSL ciphers and use them in SslTransport#1798
rytilahti merged 1 commit into
python-kasa:masterfrom
rytilahti:fix/rv10_ssl

Conversation

rytilahti commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Add kasa/transports/sslcontext.py with one shared SSL context for the https transports to avoid copies across transports.
  • Use it in SslTransport, and convert KLAP and Linkie also to use it.
  • Extend Python's default ciphers with the legacy suites instead of replacing accepted ciphers for future compatibility.

Fixes #1787

Consolidate SSL ciphers and use them in SslTransport
927a503 
- Share one compatibility SSL context between the https transports instead of three copies that had drifted apart.
- Use it in SslTransport so devices such as the RV10 Plus can complete the TLS handshake.
rytilahti added the bug Something isn't working label Oct 12, 2026

codecov Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.42%. Comparing base (a4fe376) to head (927a503).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1798      +/-   ##
==========================================
- Coverage   93.43%   93.42%   -0.01%     
==========================================
  Files         159      160       +1     
  Lines       10116    10091      -25     
  Branches     1044     1041       -3     
==========================================
- Hits         9452     9428      -24     
  Misses        471      471              
+ Partials      193      192       -1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rytilahti mentioned this pull request Oct 12, 2026
Closed
bhaybhi mentioned this pull request Oct 13, 2026
Closed
ZeliardM approved these changes Oct 14, 2026
View reviewed changes

ZeliardM left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me, thanks!

rytilahti merged commit 2a81f74 into python-kasa:master Oct 14, 2026
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeliardM ZeliardM approved these changes
sdb9696 Awaiting requested review from sdb9696
bdraco Awaiting requested review from bdraco

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tapo RV10 Plus: SSL handshake failure on port 4433

2 participants

Back | FazBrowse Home | New Git URL