Repository navigation
Fix test_deprecated_type stalling - #325
Merged
rytilahti merged 1 commit intoMar 24, 2022
Merged
rytilahti merged 1 commit into
rytilahti merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 82.04% 82.41% +0.36%
==========================================
Files 13 13
Lines 1376 1376
Branches 202 202
==========================================
+ Hits 1129 1134 +5
+ Misses 205 200 -5
Partials 42 42 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
rytilahti
approved these changes
Mar 24, 2022
rytilahti
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good catch, thanks 👍
Sorry, something went wrong.
rytilahti
pushed a commit
that referenced
this pull request
Apr 5, 2022
* Fix test_deprecated_type stalling * Fix strips with modularize * Fix test_deprecated_type stalling (#325)
rytilahti
pushed a commit
that referenced
this pull request
Apr 5, 2022
* Fix test_deprecated_type stalling * Fix strips with modularize * Fix test_deprecated_type stalling (#325)
rytilahti
added a commit
to rytilahti/python-kasa
that referenced
this pull request
Apr 5, 2022
This release fixes an issue where the bulb state on led strips was not restored properly when turned back on. [Full Changelog](python-kasa/python-kasa@0.4.2...0.4.3) **Fixed bugs:** - Divide by zero when HS300 powerstrip is discovered [\python-kasa#292](python-kasa#292) - Ensure bulb state is restored when turning back on [\python-kasa#330](python-kasa#330) (@bdraco) **Closed issues:** - KL420L5 controls [\python-kasa#327](python-kasa#327) **Merged pull requests:** - Update pre-commit hooks to fix black in CI [\python-kasa#331](python-kasa#331) (@rytilahti) - Fix test\_deprecated\_type stalling [\python-kasa#325](python-kasa#325) (@bdraco)
Merged
rytilahti
added a commit
that referenced
this pull request
Apr 5, 2022
This release fixes an issue where the bulb state on led strips was not restored properly when turned back on. [Full Changelog](0.4.2...0.4.3) **Fixed bugs:** - Divide by zero when HS300 powerstrip is discovered [\#292](#292) - Ensure bulb state is restored when turning back on [\#330](#330) (@bdraco) **Closed issues:** - KL420L5 controls [\#327](#327) **Merged pull requests:** - Update pre-commit hooks to fix black in CI [\#331](#331) (@rytilahti) - Fix test\_deprecated\_type stalling [\#325](#325) (@bdraco)
rytilahti
pushed a commit
that referenced
this pull request
Apr 5, 2022
* Fix test_deprecated_type stalling * Fix strips with modularize * Fix test_deprecated_type stalling (#325)
rytilahti
pushed a commit
that referenced
this pull request
Apr 5, 2022
* Fix test_deprecated_type stalling * Fix strips with modularize * Fix test_deprecated_type stalling (#325)
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
This release fixes an issue where the bulb state on led strips was not restored properly when turned back on. [Full Changelog](python-kasa/python-kasa@0.4.2...0.4.3) **Fixed bugs:** - Divide by zero when HS300 powerstrip is discovered [\python-kasa#292](python-kasa#292) - Ensure bulb state is restored when turning back on [\python-kasa#330](python-kasa#330) (@bdraco) **Closed issues:** - KL420L5 controls [\python-kasa#327](python-kasa#327) **Merged pull requests:** - Update pre-commit hooks to fix black in CI [\python-kasa#331](python-kasa#331) (@rytilahti) - Fix test\_deprecated\_type stalling [\python-kasa#325](python-kasa#325) (@bdraco)
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
* Fix test_deprecated_type stalling * Fix strips with modularize * Fix test_deprecated_type stalling (python-kasa#325)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests were taking a long time to run because this wasn't patched out