FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow sub-command invocation on discovered devices by rytilahti · Pull Request #392 · python-kasa/python-kasa · GitHub

Repository navigation

Allow sub-command invocation on discovered devices - #392

Closed
rytilahti wants to merge 1 commit into
python-kasa:masterfrom
rytilahti:feat/subcommands_on_discovered
Closed

rytilahti wants to merge 1 commit into
python-kasa:masterfrom
rytilahti:feat/subcommands_on_discovered

Conversation

Copy link
Copy Markdown
Member

This allows executing a single sub-command against all discovered devices.
It is not ready to be merged in its current state as it requires figuring out solutions to the issues listed below.

TBD:

  • The sub-command options are not passed to the command
  • When running on discovered devices, the original command on the dummy device needs to be suppressed to avoid crashing

Fixes #71

rytilahti added the bug Something isn't working label Nov 3, 2022

codecov-commenter commented Nov 3, 2022 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.95%. Comparing base (f32f7f3) to head (fcfd8d0).
Report is 456 commits behind head on master.

Files with missing lines Patch % Lines
kasa/cli.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
- Coverage   79.88%   78.95%   -0.93%     
==========================================
  Files          24       24              
  Lines        1770     1825      +55     
  Branches      255      266      +11     
==========================================
+ Hits         1414     1441      +27     
- Misses        322      350      +28     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rytilahti marked this pull request as draft November 7, 2022 17:12

Copy link
Copy Markdown
Member Author

Obsoleted by #982 as it's not a good idea to execute commands on an arbitrary set of devices.

rytilahti closed this Jun 15, 2024
rytilahti deleted the feat/subcommands_on_discovered branch June 15, 2024 22:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Individual commands do not work on discovered devices

2 participants


Back | FazBrowse Home | New Git URL