FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add some of my device fixtures, KL430 is for #439 by jimboca · Pull Request #441 · python-kasa/python-kasa · GitHub

  1. python-kasa
  2. python-kasa

Repository navigation

Add some of my device fixtures, KL430 is for #439 - #441

Closed
jimboca wants to merge 1 commit into
python-kasa:masterfrom
jimboca:master
ConversationCommits (1)ChecksFiles changed
Closed

Add some of my device fixtures, KL430 is for #439#441
jimboca wants to merge 1 commit into
python-kasa:masterfrom
jimboca:master

Conversation

jimboca commented Mar 19, 2023

Copy link
Copy Markdown
Contributor

Let me know if it makes sense that the KL430 is causing my issue in #439

jimboca commented Mar 19, 2023

Copy link
Copy Markdown
Contributor Author

Looks like that KL430 does cause the failure.

jimboca mentioned this pull request Mar 30, 2023
Closed

rytilahti commented Mar 30, 2023

Copy link
Copy Markdown
Member

Thanks for these! Let's wait before merging this that #440 gets done to avoid breaking the CI.

rytilahti mentioned this pull request Mar 30, 2023
Merged

rytilahti commented Apr 1, 2023

Copy link
Copy Markdown
Member

@jimboca I merged the fix, but couldn't rebase nor fix the tests for this PR. Would you mind allowing me to edit this PR to do the changes?

jimboca commented Apr 1, 2023

Copy link
Copy Markdown
Contributor Author

@jimboca I merged the fix, but couldn't rebase nor fix the tests for this PR. Would you mind allowing me to edit this PR to do the changes?

I looked and it is on?

But I also gave you permission on my Fork if that helps?

rytilahti mentioned this pull request Jun 3, 2024
Merged

rytilahti commented Jun 3, 2024

Copy link
Copy Markdown
Member

Sorry @jimboca, this somehow slipped through the cracks. I fixed the conflicts, but wasn't able to push on your branch (perhaps because it's master), so I just cherry-picked your commit & created a new PR (#948).

Thanks again!

rytilahti closed this Jun 3, 2024
rytilahti added a commit that referenced this pull request Jun 4, 2024
Add some device fixtures (#948)
40f2263 
Adds some device fixtures by courtesy of @jimboca, thanks!
This is a slightly patched and rebased version of #441.

---------

Co-authored-by: JimBo <jimboca3@gmail.com>
Co-authored-by: sdb9696 <steven.beth@gmail.com>
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
Add some device fixtures (python-kasa#948)
13b34f9 
Adds some device fixtures by courtesy of @jimboca, thanks!
This is a slightly patched and rebased version of python-kasa#441.

---------

Co-authored-by: JimBo <jimboca3@gmail.com>
Co-authored-by: sdb9696 <steven.beth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL