FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Replace asyncio.wait_for with async-timeout by bdraco · Pull Request #480 · python-kasa/python-kasa · GitHub

/ python-kasa Public

Replace asyncio.wait_for with async-timeout - #480

Merged
rytilahti merged 4 commits into
python-kasa:masterfrom
bdraco:wait_for
Jul 21, 2023
ConversationCommits (4)ChecksFiles changed
Merged

Replace asyncio.wait_for with async-timeout#480
rytilahti merged 4 commits into
python-kasa:masterfrom
bdraco:wait_for

Conversation

bdraco commented Jul 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Note: CI failure is fixed by #482

asyncio.wait_for has some underlying problems that are only fixed in cpython 3.12.

Use async_timeout instead until the minimum supported version is 3.11+ and it can be replaced with asyncio.timeout

See python/cpython#98518

codecov-commenter commented Jul 21, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (9b039d8) 79.55% compared to head (f0630f5) 79.61%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
+ Coverage   79.55%   79.61%   +0.06%     
==========================================
  Files          26       26              
  Lines        1956     1962       +6     
  Branches      599      602       +3     
==========================================
+ Hits         1556     1562       +6     
  Misses        359      359              
  Partials       41       41
Impacted Files Coverage Δ
kasa/protocol.py 86.95% <100.00%> (+0.59%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

bdraco marked this pull request as ready for review July 21, 2023 02:43
rytilahti reviewed Jul 21, 2023
View reviewed changes
Comment thread kasa/protocol.py Outdated
bdraco commented Jul 21, 2023
View reviewed changes
Comment thread kasa/protocol.py
bdraco added 4 commits July 21, 2023 04:18
Replace asyncio.wait_for with asyncio.timeout
dae93fd 
Fallback to using async_timeout on older python

asyncio.wait_for has some underlying problems that are only fixed in
cpython 3.12. See python/cpython#98518
Replace asyncio.wait_for with asyncio.timeout
fe6a6f5 
Fallback to using async_timeout on older python

asyncio.wait_for has some underlying problems that are only fixed in
cpython 3.12. See python/cpython#98518
drop asyncio.timeout until cpython 3.12 is the min supported
16c9711
drop asyncio.timeout until cpython 3.11 is the min supported
061f462
rytilahti approved these changes Jul 21, 2023
View reviewed changes

rytilahti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

rytilahti changed the title Replace asyncio.wait_for with asyncio.timeout Replace asyncio.wait_for with async-timeout Jul 21, 2023
rytilahti merged commit 117a7ac into python-kasa:master Jul 21, 2023

rytilahti commented Jul 21, 2023

Copy link
Copy Markdown
Member

How crucial it is to get this released rather sooner than later? Currently a bit busy with other things, so if a new release can wait I'd rather do it later.

bdraco commented Jul 21, 2023

Copy link
Copy Markdown
Member Author

It's hard to tell from the information users have provided if they have network problems or are getting hitting by races with wait_for which makes it difficult to give a good answer here.

I suspect we have both cases.

It would be great to have it released in time for beta on Wednesday.

rytilahti commented Jul 23, 2023

Copy link
Copy Markdown
Member

Potentially related to home-assistant/core#90636

rytilahti added the bug Something isn't working label Jul 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rytilahti rytilahti approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL